Merged
Conversation
Pull Request Test Coverage Report for Build 15690631851Details
💛 - Coveralls |
This was referenced Jun 8, 2025
* Update CHANGELOG.md
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the library to v2.0.0-beta by dropping Node.js v18 support, renaming the package scope, and updating key dependencies and tooling.
- Raise minimum Node.js requirement to v20 and add v24 support.
- Rename package to
@homebridge/hap-nodejsand update related badges. - Bump dependencies:
commanderv13→v14,jestv29→v30, migrate ESLint to a flat config.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Renamed package scope, bumped Node engine, updated versions. |
| docs/index.html | Adjusted npm badge links and labels for the new package name. |
| src/lib/util/tlv.spec.ts | Switched Jest matcher from .toThrowError() to .toThrow(). |
| eslint.config.mjs | Introduced new flat ESLint configuration, removed legacy file. |
| CHANGELOG.md | Added unreleased entry for v2.0.0 with migration notes. |
Comments suppressed due to low confidence (5)
package.json:3
- The version in package.json was not updated to v2.0.0-beta; please bump it to match the release tag.
"version": "1.2.0"
docs/index.html:6
- The href for the npm beta badge still references
hap-nodejs; update it to@homebridge/hap-nodejs.
<a href="https://www.npmjs.com/package/hap-nodejs/v/beta"><img title="npm version beta" src="https://badgen.net/npm/v/@homebridge/hap-nodejs/beta" ></a>
docs/index.html:7
- The href for the npm alpha badge still references
hap-nodejs; update it to@homebridge/hap-nodejs.
<a href="https://www.npmjs.com/package/hap-nodejs/v/alpha"><img title="npm version alpha" src="https://badgen.net/npm/v/@homebridge/hap-nodejs/alpha" ></a>
docs/index.html:8
- The href for the npm downloads badge still references
hap-nodejs; update it to@homebridge/hap-nodejs.
<a href="https://www.npmjs.com/package/hap-nodejs"><img title="npm downloads" src="https://badgen.net/npm/dt/@homebridge/hap-nodejs" ></a>
CHANGELOG.md:5
- [nitpick] Changelog header lists
v2.0.0instead of the prereleasev2.0.0-beta; consider matching the beta tag for clarity.
## v2.0.0 (Unreleased)
NorthernMan54
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
hap-nodejs: v2.0.0-beta #1094homebridge: v2.0.0-beta homebridge#3816@homebridge/hap-client: v3.0.0-beta hap-client#21homebridge-config-ui-x: v5.0.0-beta homebridge-config-ui-x#2449Changes
v20commanderfromv13tov14jesttov30and required migration stepseslinttov9and required migration steps@homebridge/hap-nodejsfor consistencyHomebridge Dependencies
@homebridge/ciao@v1.3.3@homebridge/dbus-native@v0.7.1bonjour-hap@v3.9.0