fix: detection of client premature close #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: honojs#217 Signed-off-by: Tomas Dvorak <[email protected]>
Ref: honojs#217 Signed-off-by: Tomas Dvorak <[email protected]>
usualoma
reviewed
Nov 11, 2024
Member
usualoma
left a comment
usualoma
left a comment
There was a problem hiding this comment.
Oh, that's great 👍
I have made one comment, so please check it.
Ref: honojs#217 Signed-off-by: Tomas Dvorak <[email protected]>
Member
|
Hi @Tomas2D ! To make CI pass, run the command |
Ref: honojs#217 Signed-off-by: Tomas Dvorak <[email protected]>
Contributor
Author
|
Updated. @yusukebe 👋🏻 |
yusukebe
approved these changes
Nov 12, 2024
Member
|
Thanks! Looks good to me. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix detection client premature close (connection abort).
Ref: #217