fix: return promise from stream.cancel() #249
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for the PR. Can you add a test to confirm this change fixes the error? |
Author
|
I will try my best 😃 |
The promise returned from stream.cancel() was ignored so far. This lead to unhandled promises when the stream throws during the cancel operation. In turn the whole hono node-server was shutdown. Close honojs#248
KnisterPeter
force-pushed
the
fix-dangeling-promise
branch
from
a6a70fa to
b2c85f5
Compare
Author
|
@yusukebe finally (after vacation) I managed to add a test case. Can you review it? |
Author
|
@yusukebe I think the errors are not related to my changes. Can you confirm this? |
Member
|
Hi @usualoma Do you think this change is needed? |
Member
|
Hi @yusukebe If there are other issues, I think we need to consider another approach. Hi @KnisterPeter |
Author
|
I will check and report back here. |
Author
Member
|
Woooow. Great! Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The promise returned from stream.cancel() was ignored so far. This lead to unhandled promises when the stream throws during the cancel operation. In turn the whole hono node-server was shutdown.
Close #248