Skip to content

fix: return promise from stream.cancel() #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KnisterPeter wants to merge 2 commits into from
Closed

fix: return promise from stream.cancel() #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2c85f5
fix: return promise from stream.cancel()
KnisterPeter Jul 3, 2025
d8ba36a
Merge remote-tracking branch 'upstream/main' into fix-dangeling-promise
yusukebe Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export function writeFromReadableStream(stream: ReadableStream<Uint8Array>, writ
if (stream.locked) {
throw new TypeError('ReadableStream is locked.')
} else if (writable.destroyed) {
return
return stream.cancel()
}

const reader = stream.getReader()
Expand Down
13 changes: 13 additions & 0 deletions test/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,4 +109,17 @@ describe('writeFromReadableStream', () => {
expect(enqueueCalled).toBe(true) // enqueue should succeed
expect(cancelCalled).toBe(false) // cancel should not be called
})

it('does handle rejections from canceled streams', async () => {
const stream = new ReadableStream({
async cancel() {
throw new Error('Aborted')
},
})

const destroyedWritable = new Writable()
destroyedWritable.destroy()

await expect(writeFromReadableStream(stream, destroyedWritable)).rejects.toThrow('Aborted')
})
})
Loading