Skip to content

feat(aws): enhanced s3 bucket configuration#78

Merged
fredleger merged 3 commits intomainfrom
feat/aws/enhanced-s3-bucket-config
Oct 9, 2025
Merged

feat(aws): enhanced s3 bucket configuration#78
fredleger merged 3 commits intomainfrom
feat/aws/enhanced-s3-bucket-config

Conversation

@fredleger
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the S3 bucket Terraform module by adding configurable options for server-side encryption (SSE) and versioning, making these previously hardcoded features optional while maintaining secure defaults.

  • Added sse_enabled and versioning_enabled variables with default values of true
  • Updated bucket resources to conditionally create encryption and versioning configurations based on these variables
  • Updated documentation to reflect the new configuration options

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
aws/s3-bucket/variables.tf Added two new boolean variables for SSE and versioning control
aws/s3-bucket/bucket.tf Added conditional resource creation using count parameter
aws/s3-bucket/README.md Updated documentation table with new input variables

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

fredleger and others added 2 commits October 8, 2025 17:42
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@fredleger fredleger merged commit ddfdacb into main Oct 9, 2025
3 checks passed
@fredleger fredleger deleted the feat/aws/enhanced-s3-bucket-config branch October 9, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments