Skip to content

feat(aws): enhanced s3 bucket configuration #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredleger merged 3 commits into from
Oct 9, 2025
Merged

feat(aws): enhanced s3 bucket configuration #78

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
310d6b7
feat(aws): enhanced s3 bucket configuration
fredleger Oct 8, 2025
31249ec
Update aws/s3-bucket/bucket.tf
fredleger Oct 8, 2025
4d0bc4f
Update aws/s3-bucket/bucket.tf
fredleger Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions aws/s3-bucket/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ No modules.
| <a name="input_object_lock_enabled"></a> [object\_lock\_enabled](#input\_object\_lock\_enabled) | A boolean that indicates whether this bucket has an Object Lock configuration enabled. Enable Object Lock to prevent objects from being deleted or overwritten for a fixed amount of time or indefinitely. | `bool` | `false` | no |
| <a name="input_object_ownership"></a> [object\_ownership](#input\_object\_ownership) | The container element for object ownership for a bucket's ownership controls. | `string` | `"BucketOwnerPreferred"` | no |
| <a name="input_restrict_public_buckets"></a> [restrict\_public\_buckets](#input\_restrict\_public\_buckets) | Whether Amazon S3 should restrict public bucket policies for this bucket. Defaults to true. | `bool` | `true` | no |
| <a name="input_sse_enabled"></a> [sse\_enabled](#input\_sse\_enabled) | A boolean that indicates whether this bucket has SSE enabled. | `bool` | `true` | no |
| <a name="input_tags"></a> [tags](#input\_tags) | Default tags to add to resources | `map(any)` | `{}` | no |
| <a name="input_versioning_enabled"></a> [versioning\_enabled](#input\_versioning\_enabled) | A boolean that indicates whether this bucket has versioning enabled. | `bool` | `true` | no |

## Outputs

Expand Down
3 changes: 3 additions & 0 deletions aws/s3-bucket/bucket.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ resource "aws_s3_bucket_public_access_block" "bucket_public_access" {
}

resource "aws_s3_bucket_server_side_encryption_configuration" "encryption" {
count = var.sse_enabled == true ? 1 : 0
bucket = aws_s3_bucket.bucket.id

rule {
Expand All @@ -40,6 +41,7 @@ resource "aws_s3_bucket_server_side_encryption_configuration" "encryption" {
}

resource "aws_s3_bucket_versioning" "versioning" {
count = var.versioning_enabled == true ? 1 : 0
bucket = aws_s3_bucket.bucket.id
versioning_configuration {
status = "Enabled"
Expand All @@ -48,6 +50,7 @@ resource "aws_s3_bucket_versioning" "versioning" {

resource "aws_s3_bucket_ownership_controls" "default" {
#checkov:skip=CKV2_AWS_65:this is up to the user
count = var.object_ownership != null ? 1 : 0
bucket = aws_s3_bucket.bucket.id
rule {
object_ownership = var.object_ownership
Expand Down
12 changes: 12 additions & 0 deletions aws/s3-bucket/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,18 @@ variable "object_lock_enabled" {
default = false
}

variable "sse_enabled" {
description = "A boolean that indicates whether this bucket has SSE enabled."
type = bool
default = true
}

variable "versioning_enabled" {
description = "A boolean that indicates whether this bucket has versioning enabled."
type = bool
default = true
}

# -------------------------------------------------------------------
# public access config
# -------------------------------------------------------------------
Expand Down
Loading