Fix file handle leaks in config.py (use context managers)#35
Open
PrasannaPal21 wants to merge 1 commit intohpc-io:masterfrom
Open
Fix file handle leaks in config.py (use context managers)#35PrasannaPal21 wants to merge 1 commit intohpc-io:masterfrom
PrasannaPal21 wants to merge 1 commit intohpc-io:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use context managers when opening JSON config files so file handles are always closed, and specify UTF-8 encoding for consistent behavior across platforms.
Previously, file handles were never closed, which can leak resources and is poor practice.
with open(...) ensures the file is closed even on exceptions.
and encoding='utf-8' matches JSON and avoids platform-dependent default encodings.