Skip to content

Fix file handle leaks in config.py (use context managers) #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PrasannaPal21 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix file handle leaks in config.py (use context managers) #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions drishti/includes/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ def load_json():
codes = []
if not args.split_files:
if args.json:
f = open(args.json)
data = json.load(f)
with open(args.json, encoding='utf-8') as f:
data = json.load(f)

for key, values in data.items():
for value in values:
Expand All @@ -169,8 +169,8 @@ def validate_thresholds():
Validate thresholds defined by the user.
"""
if args.config:
f = open(args.config)
data = json.load(f)
with open(args.config, encoding='utf-8') as f:
data = json.load(f)

for category, thresholds_spec in data.items():
for threshold_name, threshold_value in thresholds_spec.items():
Expand Down