Skip to content

Conversation

@houjun
Copy link
Member

@houjun houjun commented Nov 11, 2025

Related Issues / Pull Requests

Description

Replace vpicio and bdcats with multiple time step version.
Also fixed a MPI_Barrier issue that may be triggered when some client need to send the data to multiple servers while others only need to send to one server.

What changes are proposed in this pull request?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected; for instance, examples in this repository must be updated too)
  • This change requires a documentation update

Checklist:

  • My code modifies existing public API, or introduces new public API, and I updated or wrote docstrings
  • I have commented my code
  • My code requires documentation updates, and I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@houjun houjun marked this pull request as ready for review November 12, 2025 18:56
@houjun houjun requested a review from a team as a code owner November 12, 2025 18:56
if (comm != 0)
MPI_Barrier(comm);
#endif
/* #ifdef ENABLE_MPI */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the commented out for now as a placeholder, may need to revisit the barrier setting if we need performance improvement.

@houjun
Copy link
Member Author

houjun commented Nov 12, 2025

@jeanbez, the "NERSC / Perlmutter" CI check doesn't seem to report back to github even after all are passed, any idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants