Skip to content

Replace vpicio and bdcats with multiple time step version #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Replace vpicio and bdcats with multiple time step version #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2608be1
Fix a mismatch issue with vpic and bdcats
houjun Nov 11, 2025
8700e18
Replace old vpicio and bdcats with mts version
houjun Nov 11, 2025
2a3ca2d
update run cmd
houjun Nov 11, 2025
77e0541
Update arguments processing
houjun Nov 11, 2025
05bc4a4
remove unnecessary code
houjun Nov 11, 2025
28da75e
remove unnecessary header and timing code
houjun Nov 11, 2025
822e3aa
remove unnecessary code
houjun Nov 11, 2025
30d237c
Committing clang-format changes
github-actions[bot] Nov 11, 2025
c474a5b
Remove unnecessary call
houjun Nov 11, 2025
9de7961
Remove barrier to prevent a deadlock of MPI_Barrier
houjun Nov 12, 2025
141ce6d
Committing clang-format changes
github-actions[bot] Nov 12, 2025
94777b4
Trigger CI
houjun Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/api/pdc_client_connect.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3036,10 +3036,10 @@ PDC_Client_transfer_request_all(hg_bulk_t *bulk_handle, int n_objs, pdc_access_t
hg_ret = HG_Forward(client_send_transfer_request_all_handle, client_send_transfer_request_all_rpc_cb,
&transfer_args, &in);

#ifdef ENABLE_MPI
if (comm != 0)
MPI_Barrier(comm);
#endif
/* #ifdef ENABLE_MPI */
Copy link
Member Author

@houjun houjun Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the commented out for now as a placeholder, may need to revisit the barrier setting if we need performance improvement.

/* if (comm != 0) */
/* MPI_Barrier(comm); */
/* #endif */

PDC_Client_transfer_pthread_create();

Expand All @@ -3058,10 +3058,10 @@ PDC_Client_transfer_request_all(hg_bulk_t *bulk_handle, int n_objs, pdc_access_t

PDC_Client_wait_pthread_progress();

#ifdef ENABLE_MPI
if (comm != 0)
MPI_Barrier(comm);
#endif
/* #ifdef ENABLE_MPI */
/* if (comm != 0) */
/* MPI_Barrier(comm); */
/* #endif */

#ifdef PDC_TIMING
end = MPI_Wtime();
Expand Down
4 changes: 0 additions & 4 deletions src/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,7 @@ set(PROGRAMS
obj/obj_round_robin_io_all
obj/delete_obj
misc/vpicio
misc/vpicio_mts
misc/bdcats
misc/bdcats_mts
deprecated/vpicio_old
deprecated/bdcats_old
tags/kvtag_add_get
tags/kvtag_query
region/region_transfer_query
Expand Down
Loading
Loading