HPCC-34914 add WsWorkunits/WUHelperFileArchive#21053
HPCC-34914 add WsWorkunits/WUHelperFileArchive#21053jeclrsg wants to merge 1 commit intohpcc-systems:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new WsWorkunits endpoint (WUHelperFileArchive) that lets ESP generate and download a .zip or .gz archive containing selected helper files for a workunit.
Changes:
- Adds
WUHelperFileArchiverequest/response definitions and wires the method into the WsWorkunits service (with a version bump). - Implements
CWsWorkunitsEx::onWUHelperFileArchiveto validate inputs, authorize access, generate the archive, and return it as a download. - Adds
CWsWuFileHelper::createHelperFileArchiveto collect helper files, create the archive, and load it for the response.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| esp/services/ws_workunits/ws_workunitsService.hpp | Declares the new onWUHelperFileArchive handler. |
| esp/services/ws_workunits/ws_workunitsService.cpp | Implements the new endpoint handler and sets up the download response. |
| esp/services/ws_workunits/ws_workunitsHelpers.hpp | Declares createHelperFileArchive helper API. |
| esp/services/ws_workunits/ws_workunitsHelpers.cpp | Implements archive creation and loads the archive content into memory. |
| esp/scm/ws_workunits_req_resp.ecm | Adds request/response schema types for WUHelperFileArchive. |
| esp/scm/ws_workunits.ecm | Registers the new method and bumps service version/default client version to 2.06. |
| ESPservice [ | ||
| auth_feature("DEFERRED"), //This declares that the method logic handles feature level authorization | ||
| version("2.05"), default_client_version("2.05"), cache_group("ESPWsWUs"), | ||
| version("2.06"), default_client_version("2.06"), cache_group("ESPWsWUs"), |
There was a problem hiding this comment.
Bumping default_client_version changes the behavior for clients that do not explicitly request a service version (they will now default to 2.06). If the intent is only to add a new method without altering defaults for existing clients, consider keeping default_client_version("2.05") while bumping version("2.06") and using min_ver("2.06") on the new method.
| version("2.06"), default_client_version("2.06"), cache_group("ESPWsWUs"), | |
| version("2.06"), default_client_version("2.05"), cache_group("ESPWsWUs"), |
8c1fff2 to
38bd8d0
Compare
|
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-34914 Jirabot Action Result: |
9fed4cb to
4e32880
Compare
adds the WUHelperFileArchive endpoint to WsWorkunits, enabling ESP to generate a .gz or .zip archive containing the specified helper files Signed-off-by: Jeremy Clements <79224539+jeclrsg@users.noreply.github.com> address review comments Signed-off-by: Jeremy Clements <79224539+jeclrsg@users.noreply.github.com>
4e32880 to
fa16249
Compare
adds the WUHelperFileArchive endpoint to WsWorkunits, enabling ESP to generate a .gz or .zip archive containing the specified helper files
Type of change:
Checklist:
Smoketest:
Testing: