Skip to content

HPCC-35956 Fix invalid c++ type generated for type_filepos#21072

Open
ghalliday wants to merge 1 commit intohpcc-systems:candidate-10.0.xfrom
ghalliday:issue35962
Open

HPCC-35956 Fix invalid c++ type generated for type_filepos#21072
ghalliday wants to merge 1 commit intohpcc-systems:candidate-10.0.xfrom
ghalliday:issue35962

Conversation

@ghalliday
Copy link
Member

@ghalliday ghalliday commented Mar 6, 2026

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
@ghalliday ghalliday requested review from Copilot and dcamper March 6, 2026 10:57
@ghalliday ghalliday added the Bug label Mar 6, 2026
@ghalliday
Copy link
Member Author

@dcamper see jira comments - I can't reproduce any longer.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes incorrect C++ type generation for type_filepos by preventing generateType() from following the base type in that case.

Changes:

  • Stop traversing the base type chain when handling type_filepos/type_blob in HqlCppWriter::generateType().

case type_filepos:
case type_blob:
prefix = intTypeName(8-1, compiler, false);
next = nullptr; // Do not follow the base type of a type_filepos
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new next = nullptr; applies to both type_filepos and type_blob because of the shared fallthrough, but the comment only references type_filepos. This is misleading and makes it unclear whether blocking base-type traversal for type_blob is intentional. Consider either splitting the cases so only type_filepos sets next = nullptr, or updating the comment to reflect that both type_filepos and type_blob should not follow their base type.

Suggested change
next = nullptr; // Do not follow the base type of a type_filepos
next = nullptr; // Do not follow the base type of type_filepos or type_blob

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-35956

Jirabot Action Result:
Workflow Transition To: Merge Pending
Additional PR: #21072

Copy link
Contributor

@dcamper dcamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants