HPCC-35956 Fix invalid c++ type generated for type_filepos#21072
HPCC-35956 Fix invalid c++ type generated for type_filepos#21072ghalliday wants to merge 1 commit intohpcc-systems:candidate-10.0.xfrom
Conversation
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
|
@dcamper see jira comments - I can't reproduce any longer. |
There was a problem hiding this comment.
Pull request overview
Fixes incorrect C++ type generation for type_filepos by preventing generateType() from following the base type in that case.
Changes:
- Stop traversing the base type chain when handling
type_filepos/type_blobinHqlCppWriter::generateType().
| case type_filepos: | ||
| case type_blob: | ||
| prefix = intTypeName(8-1, compiler, false); | ||
| next = nullptr; // Do not follow the base type of a type_filepos |
There was a problem hiding this comment.
The new next = nullptr; applies to both type_filepos and type_blob because of the shared fallthrough, but the comment only references type_filepos. This is misleading and makes it unclear whether blocking base-type traversal for type_blob is intentional. Consider either splitting the cases so only type_filepos sets next = nullptr, or updating the comment to reflect that both type_filepos and type_blob should not follow their base type.
| next = nullptr; // Do not follow the base type of a type_filepos | |
| next = nullptr; // Do not follow the base type of type_filepos or type_blob |
|
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-35956 Jirabot Action Result: |
Type of change:
Checklist:
Smoketest:
Testing: