Skip to content

HPCC-35956 Fix invalid c++ type generated for type_filepos #21072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghalliday wants to merge 1 commit into
base: candidate-10.0.x
Choose a base branch
from
+1 −0
Open

HPCC-35956 Fix invalid c++ type generated for type_filepos #21072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ecl/hqlcpp/hqlwcpp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,7 @@ void HqlCppWriter::generateType(ITypeInfo * type, const char * name)
case type_filepos:
case type_blob:
prefix = intTypeName(8-1, compiler, false);
next = nullptr; // Do not follow the base type of a type_filepos
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new next = nullptr; applies to both type_filepos and type_blob because of the shared fallthrough, but the comment only references type_filepos. This is misleading and makes it unclear whether blocking base-type traversal for type_blob is intentional. Consider either splitting the cases so only type_filepos sets next = nullptr, or updating the comment to reflect that both type_filepos and type_blob should not follow their base type.

Suggested change
next = nullptr; // Do not follow the base type of a type_filepos
next = nullptr; // Do not follow the base type of type_filepos or type_blob

Copilot uses AI. Check for mistakes.
break;
case type_keyedint:
break;
Expand Down
Loading