-
Notifications
You must be signed in to change notification settings - Fork 2
BC-10251 replace bitnami container image #1220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Loki-Afro
wants to merge
15
commits into
main
Choose a base branch
from
bc-10251
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddacf1e to
2108cfb
Compare
52ab7c4 to
6a524d5
Compare
1 task
mamutmk5
requested changes
Aug 13, 2025
Comment on lines
22
to
28
| sentinelResources: | ||
| limits: | ||
| cpu: "{{ SESSION_VALKEY_CPU_LIMITS|default('1000m', true) }}" | ||
| memory: "{{ SESSION_VALKEY_MEMORY_LIMITS|default('4Gi', true) }}" | ||
| requests: | ||
| cpu: "{{ SESSION_VALKEY_CPU_REQUESTS|default('100m', true) }}" | ||
| memory: "{{ SESSION_VALKEY_MEMORY_REQUESTS|default('1Gi', true) }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoud have the sentinel container the same amount of resources as the Valkey container at the pod?
mamutmk5
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
special thanks to @groundhog2k for fixing groundhog2k/helm-charts#1401
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/BC-10251
hpi-schul-cloud/tldraw-server#73
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Screenshots of UI changes
Approval for review