-
Notifications
You must be signed in to change notification settings - Fork 2
BC-10251 replace bitnami container image #1220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Loki-Afro
wants to merge
15
commits into
main
Choose a base branch
from
bc-10251
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
eda9948
BC-10251 replace bitnami container image
Loki-Afro ed7e828
temp
Loki-Afro 64a96c3
temp
Loki-Afro 9be4f70
lets break stuff
Loki-Afro 7fabd50
template in template, i love my live
Loki-Afro e7d0729
sa
Loki-Afro bbbe790
fix warning
Loki-Afro 5d56f2e
Trigger Build
Loki-Afro 3b77df9
reintroduce warning
Loki-Afro d5a795a
apply helm update
Loki-Afro 1aa6bae
clean up
Loki-Afro 6ee3a35
fix naming
Loki-Afro ec04efa
Merge branch 'main' into bc-10251
Loki-Afro fdfbfb2
add requirement to externals ecrets operator
Loki-Afro 169eee2
fix sentinel and exporter resources
Loki-Afro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| session-valkey-password(1pwd) -> session-valkey-password(secret) -> session-valkey-auth(externalsecret) -> session-valkey-auth(secret) | ||
| -> session-valkey-auth(externalsecret) -> session-valkey-sentinel-config(secret) | ||
| -> session-valkey-auth(externalsecret) -> session-valkey-exporter-config(secret) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,5 @@ | ||
| SESSION_VALKEY_CHART_VERSION: 3.0.22 | ||
| SESSION_VALKEY_CHART_VERSION: 2.1.2 | ||
|
|
||
| SESSION_VALKEY_IMAGE_VERSION: 8.1.3 | ||
| SESSION_VALKEY_REDIS_EXPORTER_IMAGE_VERSION: v1.74.0 | ||
| SESSION_VALKEY_REPLICAS: 3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
ansible/roles/session-valkey/templates/es-valkey-config.yml.j2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| apiVersion: external-secrets.io/v1beta1 | ||
| kind: ExternalSecret | ||
| metadata: | ||
| name: session-valkey-config | ||
| namespace: {{ NAMESPACE }} | ||
| labels: | ||
| app: session-valkey | ||
| spec: | ||
| refreshInterval: {{ EXTERNAL_SECRETS_REFRESH_INTERVAL }} | ||
| secretStoreRef: | ||
| kind: SecretStore | ||
| name: {{ EXTERNAL_SECRETS_K8S_STORE }} | ||
| target: | ||
| name: session-valkey-config | ||
| template: | ||
| engineVersion: v2 | ||
| data: | ||
| valkey-auth.conf: | | ||
| requirepass "{% raw %}{{ .SESSION_VALKEY__SENTINEL_PASSWORD }}{% endraw %}" | ||
| masterauth "{% raw %}{{ .SESSION_VALKEY__SENTINEL_PASSWORD }}{% endraw %}" | ||
| dataFrom: | ||
| - extract: | ||
| key: session-valkey-password |
21 changes: 21 additions & 0 deletions
21
ansible/roles/session-valkey/templates/es-valkey-exporter.yml.j2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| apiVersion: external-secrets.io/v1beta1 | ||
| kind: ExternalSecret | ||
| metadata: | ||
| name: session-valkey-exporter | ||
| namespace: {{ NAMESPACE }} | ||
| labels: | ||
| app: session-valkey | ||
| spec: | ||
| refreshInterval: {{ EXTERNAL_SECRETS_REFRESH_INTERVAL }} | ||
| secretStoreRef: | ||
| kind: SecretStore | ||
| name: {{ EXTERNAL_SECRETS_K8S_STORE }} | ||
| target: | ||
| name: session-valkey-exporter | ||
| template: | ||
| engineVersion: v2 | ||
| data: | ||
| REDIS_PASSWORD: "{% raw %}{{ .SESSION_VALKEY__SENTINEL_PASSWORD }}{% endraw %}" | ||
| dataFrom: | ||
| - extract: | ||
| key: session-valkey-password |
22 changes: 22 additions & 0 deletions
22
ansible/roles/session-valkey/templates/es-valkey-sentinel-config.yml.j2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| apiVersion: external-secrets.io/v1beta1 | ||
| kind: ExternalSecret | ||
| metadata: | ||
| name: session-valkey-sentinel-config | ||
| namespace: {{ NAMESPACE }} | ||
| labels: | ||
| app: session-valkey | ||
| spec: | ||
| refreshInterval: {{ EXTERNAL_SECRETS_REFRESH_INTERVAL }} | ||
| secretStoreRef: | ||
| kind: SecretStore | ||
| name: {{ EXTERNAL_SECRETS_K8S_STORE }} | ||
| target: | ||
| name: session-valkey-sentinel-config | ||
| template: | ||
| engineVersion: v2 | ||
| data: | ||
| sentinel-auth.conf: | | ||
| sentinel auth-pass myprimary "{% raw %}{{ .SESSION_VALKEY__SENTINEL_PASSWORD }}{% endraw %}" | ||
| dataFrom: | ||
| - extract: | ||
| key: session-valkey-password |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,54 +1,59 @@ | ||
| global: | ||
| defaultStorageClass: "{{ SC_DEFAULT_STORAGE_CLASS_NAME }}" | ||
| replica: | ||
| replicaCount: {{ SESSION_VALKEY_REPLICAS }} | ||
| pdb: | ||
| create: false | ||
| resources: | ||
| limits: | ||
| cpu: "{{ SESSION_VALKEY_CPU_LIMITS|default('1000m', true) }}" | ||
| memory: "{{ SESSION_VALKEY_MEMORY_LIMITS|default('4Gi', true) }}" | ||
| requests: | ||
| cpu: "{{ SESSION_VALKEY_CPU_REQUESTS|default('100m', true) }}" | ||
| memory: "{{ SESSION_VALKEY_MEMORY_REQUESTS|default('1Gi', true) }}" | ||
| primary: | ||
| pdb: | ||
| create: false | ||
| readinessProbe: | ||
| timeoutSeconds: 5 | ||
| resources: | ||
| limits: | ||
| cpu: "{{ SESSION_VALKEY_CPU_LIMITS|default('1000m', true) }}" | ||
| memory: "{{ SESSION_VALKEY_MEMORY_LIMITS|default('4Gi', true) }}" | ||
| requests: | ||
| cpu: "{{ SESSION_VALKEY_CPU_REQUESTS|default('100m', true) }}" | ||
| memory: "{{ SESSION_VALKEY_MEMORY_REQUESTS|default('1Gi', true) }}" | ||
| auth: | ||
| existingSecret: session-valkey-password | ||
| existingSecretPasswordKey: SESSION_VALKEY__SENTINEL_PASSWORD | ||
| usePasswordFiles: false | ||
| sentinel: | ||
| storage: | ||
| className: "{{ SC_DEFAULT_STORAGE_CLASS_NAME }}" | ||
|
|
||
| haMode: | ||
| enabled: true | ||
| readinessProbe: | ||
| timeoutSeconds: 5 | ||
| replicas: {{ SESSION_VALKEY_REPLICAS }} | ||
| masterGroupName: myprimary | ||
|
|
||
| image: | ||
| registry: "docker.io" | ||
| repository: "valkey/valkey" | ||
| tag: "{{ SESSION_VALKEY_IMAGE_VERSION }}" | ||
|
|
||
| resources: | ||
| limits: | ||
| cpu: "{{ SESSION_VALKEY_CPU_LIMITS|default('1000m', true) }}" | ||
| memory: "{{ SESSION_VALKEY_MEMORY_LIMITS|default('4Gi', true) }}" | ||
| requests: | ||
| cpu: "{{ SESSION_VALKEY_CPU_REQUESTS|default('100m', true) }}" | ||
| memory: "{{ SESSION_VALKEY_MEMORY_REQUESTS|default('1Gi', true) }}" | ||
|
|
||
| sentinelResources: | ||
| limits: | ||
| cpu: "{{ SESSION_VALKEY_CPU_LIMITS|default('1000m', true) }}" | ||
| memory: "{{ SESSION_VALKEY_MEMORY_LIMITS|default('4Gi', true) }}" | ||
| requests: | ||
| cpu: "{{ SESSION_VALKEY_CPU_REQUESTS|default('100m', true) }}" | ||
| memory: "{{ SESSION_VALKEY_MEMORY_REQUESTS|default('1Gi', true) }}" | ||
|
|
||
| extraSecretValkeyConfigs: "session-valkey-config" | ||
| extraSecretSentinelConfigs: "session-valkey-sentinel-config" | ||
|
|
||
| metrics: | ||
| enabled: true | ||
| podMonitor: | ||
| enabled: true | ||
| extraArgs: | ||
| check-key-groups: '\(jwt\):.+' | ||
| exporter: | ||
| image: | ||
| registry: "docker.io" | ||
| repository: "oliver006/redis_exporter" | ||
| tag: "{{ SESSION_VALKEY_REDIS_EXPORTER_IMAGE_VERSION }}" | ||
| resources: | ||
| limits: | ||
| cpu: "{{ SESSION_VALKEY_EXPORTER_CPU_LIMITS|default('1000m', true) }}" | ||
| memory: "{{ SESSION_VALKEY_EXPORTER_MEMORY_LIMITS|default('1Gi', true) }}" | ||
| requests: | ||
| cpu: "{{ SESSION_VALKEY_EXPORTER_CPU_REQUESTS|default('100m', true) }}" | ||
| memory: "{{ SESSION_VALKEY_EXPORTER_MEMORY_REQUESTS|default('1Gi', true) }}" | ||
| args: | ||
| - --check-key-groups=(jwt):.+ | ||
| extraExporterEnvSecrets: | ||
| - "session-valkey-exporter" | ||
| serviceMonitor: | ||
| enabled: true | ||
| metricRelabelings: | ||
| - sourceLabels: [ __name__ ] | ||
| regex: redis_key_group_count | ||
| action: replace | ||
| targetLabel: longterm | ||
| replacement: "true" | ||
| # OPS-6762 still up to debate if we will enable this | ||
| networkPolicy: | ||
| enabled: false | ||
| serviceAccount: | ||
| create: false | ||
| # https://github.com/bitnami/charts/issues/9689 | ||
| useHostnames: false | ||
| interval: 30s | ||
| extraEndpointParameters: | ||
| metricRelabelings: | ||
| - sourceLabels: [ __name__ ] | ||
| regex: redis_key_group_count | ||
| action: replace | ||
| targetLabel: longterm | ||
| replacement: "true" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoud have the sentinel container the same amount of resources as the Valkey container at the pod?