BC-9255 make changes in hpi-schul-cloud/ckeditor testable in dev environment #3600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loki-Afro
changed the title
1 task
dyedwiper
reviewed
Mar 28, 2025
| "@braintree/sanitize-url": "^7.1.1", | ||
| "@ckeditor/ckeditor5-vue": "^5.1.0", | ||
| "@hpi-schul-cloud/ckeditor": "^1.2.0", | ||
| "@hpi-schul-cloud/ckeditor": "^0.0.1-4c867f8376b47589cb9696054927d8ba2bec1e21", |
There was a problem hiding this comment.
Das soll aber nicht mit gemerget werden.
dyedwiper
reviewed
Mar 28, 2025
Comment on lines
+8
to
+9
| # Write the .npmrc file only if the GitHub token is provided | ||
| # A token is always required to access GitHub's npm registry |
There was a problem hiding this comment.
Suggested change
| # Write the .npmrc file only if the GitHub token is provided | |
| # A token is always required to access GitHub's npm registry | |
| # A token to access GitHub's npm registry is added here conditionally. We use Github's npm reqistry for pre-release versions of our own packages (e.g. @hpi-schul-cloud/ckeditor). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Links to Ticket and related Pull-Requests
https://ticketsystem.dbildungscloud.de/browse/BC-9255
hpi-schul-cloud/ckeditor#19
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging