Skip to content

BC-9255 make changes in hpi-schul-cloud/ckeditor testable in dev environment #3600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

BC-9255 make changes in hpi-schul-cloud/ckeditor testable in dev environment #3600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7dd8d72
test fancy dependency
Loki-Afro Mar 12, 2025
f2ea71b
test test
Loki-Afro Mar 12, 2025
e5af232
clean clean
Loki-Afro Mar 12, 2025
16a4288
clean clean
Loki-Afro Mar 12, 2025
239bda1
clean clean
Loki-Afro Mar 12, 2025
11a1454
added comment
Loki-Afro Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ jobs:
with:
build-args: |
SC_THEME=${{ matrix.tenants }}
# this is only needed when using the github registry
secrets: |
GIT_AUTH_TOKEN=${{ github.token }}
context: .
file: ./Dockerfile
platforms: linux/amd64
Expand Down
10 changes: 9 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,15 @@ FROM docker.io/node:22 AS build-stage
WORKDIR /app

COPY package.json package-lock.json ./
RUN npm ci --ignore-scripts

# Write the .npmrc file only if the GitHub token is provided
# A token is always required to access GitHub's npm registry
Comment on lines +8 to +9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Write the .npmrc file only if the GitHub token is provided
# A token is always required to access GitHub's npm registry
# A token to access GitHub's npm registry is added here conditionally. We use Github's npm reqistry for pre-release versions of our own packages (e.g. @hpi-schul-cloud/ckeditor).

RUN --mount=type=secret,id=GIT_AUTH_TOKEN \
if [ -f /run/secrets/GIT_AUTH_TOKEN ]; then \
echo "//npm.pkg.github.com/:_authToken=$(cat /run/secrets/GIT_AUTH_TOKEN)" > ~/.npmrc; \
fi && \
npm ci --ignore-scripts && \
rm -f ~/.npmrc

COPY babel.config.js eslint.config.js LICENSE.md .prettierrc.js tsconfig.json tsconfig.build.json .prettierignore ./
COPY lib/eslint-plugin-schulcloud ./lib/eslint-plugin-schulcloud
Expand Down
6 changes: 4 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"dependencies": {
"@braintree/sanitize-url": "^7.1.1",
"@ckeditor/ckeditor5-vue": "^5.1.0",
"@hpi-schul-cloud/ckeditor": "^1.2.0",
"@hpi-schul-cloud/ckeditor": "^0.0.1-4c867f8376b47589cb9696054927d8ba2bec1e21",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das soll aber nicht mit gemerget werden.

"@lumieducation/h5p-webcomponents": "^9.2.2",
"@vuelidate/core": "^2.0.3",
"@vuelidate/validators": "^2.0.4",
Expand Down