Skip to content

Fix tokenizers install from main in LoRA tests #10494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 8, 2025
Merged

Fix tokenizers install from main in LoRA tests #10494

merged 7 commits into from
Jan 8, 2025

Conversation

@hlky
Copy link
Contributor

@hlky hlky commented Jan 8, 2025

What does this PR do?

#10132

Tokenizers Installation

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sayakpaul @DN6

@sayakpaul sayakpaul mentioned this pull request Jan 8, 2025
Closed
@hlky
Copy link
Contributor Author

hlky commented Jan 8, 2025

https://github.com/huggingface/diffusers/actions/runs/12670063594/job/35308957154?pr=10494#step:6:236

/opt/venv/src/transformers/src/transformers/utils/versions.py:44: in _compare_versions
    raise ImportError(
E   ImportError: tokenizers>=0.21,<0.22 is required for a normal functioning of this module, but found tokenizers==0.21.0.dev0.

Seems transformers doesn't work with dev versions of tokenizers.

Maybe just revert this.

sayakpaul
sayakpaul reviewed Jan 8, 2025
View reviewed changes
.github/workflows/pr_tests.yml
pip install -e git+https://github.com/huggingface/transformers.git#egg=transformers --no-deps
python -m uv pip install -U tokenizers@git+https://github.com/huggingface/tokenizers.git#subdirectory=bindings/python --no-deps
python -m uv pip install -U transformers@git+https://github.com/huggingface/transformers.git --no-deps
python -m uv pip install -U tokenizers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10494 (comment)

@hlky hlky merged commit 4df9d49 into huggingface:main Jan 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sayakpaul sayakpaul sayakpaul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hlky @sayakpaul