Skip to content

Fix tokenizers install from main in LoRA tests #10494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 8, 2025
Merged

Fix tokenizers install from main in LoRA tests #10494

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2627219
Fix tokenizers install from main in LoRA tests
hlky Jan 8, 2025
70235af
@
hlky Jan 8, 2025
a7efc4a
rust
hlky Jan 8, 2025
ae7b28d
-e
hlky Jan 8, 2025
83a616f
uv
hlky Jan 8, 2025
412e621
just update tokenizers
hlky Jan 8, 2025
339793d
Merge branch 'main' into lora-test-tokenizers
hlky Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ jobs:
# TODO (sayakpaul, DN6): revisit `--no-deps`
python -m pip install -U peft@git+https://github.com/huggingface/peft.git --no-deps
python -m uv pip install -U transformers@git+https://github.com/huggingface/transformers.git --no-deps
python -m uv pip install -U tokenizers@git+https://github.com/huggingface/tokenizers.git --no-deps
python -m uv pip install -U tokenizers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10494 (comment)

pip uninstall accelerate -y && python -m uv pip install -U accelerate@git+https://github.com/huggingface/accelerate.git --no-deps

- name: Environment
Expand Down
Loading