Skip to content

enable dit integration cases on xpu #11523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 9, 2025
Merged

enable dit integration cases on xpu #11523

merged 5 commits into from
May 9, 2025

Conversation

@yao-matrix
Copy link
Contributor

@yao-matrix yao-matrix commented May 8, 2025 •
edited
Loading

for test_dit_512 case, both A100 and XPU don't pass with current pixel delta criteria(yes, as we noticed many times, there 2 have similar numerical behavior), I propose to use cosine similarity as some of other cases used(like controlnet_impaint). With proposed changes, both XPU and A100 passed.

@DN6 @a-r-r-o-w , pls help review, thx.

a-r-r-o-w
a-r-r-o-w approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@a-r-r-o-w a-r-r-o-w merged commit d6bf268 into huggingface:main May 9, 2025
8 checks passed
@yao-matrix yao-matrix deleted the dit-xpu branch May 11, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yao-matrix @a-r-r-o-w