-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Loose the criteria tolerance appropriately for Intel XPU devices #12460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loose the criteria tolerance appropriately for Intel XPU devices #12460
Conversation
Signed-off-by: Liu, Kaixuan <[email protected]>
|
tolerance as |
|
This PR is aimed to solve two precision failed test cases in diffusers CI on Intel XPU platform: for case 1, I compared the output images, they are perceptualy same(see attached output.bmp for case 2, maybe the |
Signed-off-by: Liu, Kaixuan <[email protected]>
|
For case2, pls refer to the analysis and fix in #12474 |
|
@a-r-r-o-w @DN6 , Hi, can you help review? Thx! |
| assert image.shape == (512, 512, 3) | ||
| max_diff = numpy_cosine_similarity_distance(expected_image.flatten(), image.flatten()) | ||
| assert max_diff < 2e-4 | ||
| assert max_diff < 2e-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you define it depending on the platform, it doesn't make sense to loosen it for everyone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, do you think it's OK now?
Signed-off-by: Liu, Kaixuan <[email protected]>
@DN6 pls help review, thx!