Skip to content

Loose the criteria tolerance appropriately for Intel XPU devices #12460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 24, 2025
Merged

Loose the criteria tolerance appropriately for Intel XPU devices #12460

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dca2502
Loose the criteria tolerance appropriately for Intel XPU devices
kaixuanliu Oct 10, 2025
ef2a9b9
Merge branch 'main' into xpu-ut-precision
kaixuanliu Oct 11, 2025
91eb9f8
change back the atol value
kaixuanliu Oct 11, 2025
d557560
use expectations
kaixuanliu Oct 22, 2025
2d77e3e
Update tests/pipelines/kandinsky2_2/test_kandinsky_controlnet.py
IlyasMoutawwakil Oct 22, 2025
5566804
Merge branch 'main' into xpu-ut-precision
kaixuanliu Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/pipelines/kandinsky2_2/test_kandinsky_controlnet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,4 +290,4 @@ def test_kandinsky_controlnet(self):

assert image.shape == (512, 512, 3)
max_diff = numpy_cosine_similarity_distance(expected_image.flatten(), image.flatten())
assert max_diff < 2e-4
assert max_diff < 2e-3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you define it depending on the platform, it doesn't make sense to loosen it for everyone.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, do you think it's OK now?