-
Notifications
You must be signed in to change notification settings - Fork 835
add style bot GitHub action #2898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Tested the workflow here : https://github.com/hanouticelina/huggingface_hub/pull/1 and it works like a charm 😃 I tested also with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely!
|
Nice to have this reusable workflow. Let's try to avoid any (some of them are OK probably, but if we can avoid using any of it, it's easier for review) |
@ydshieh do you have an alternative to substitute a command? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looking forward to using it on a practical use case 😄
Regarding the run command I do think it's important to have it configurable -if there is any way to make it secure enough-.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it!
For example you can make it You can see this is applied in many places. Note this is necessary for security for any context that could be related to user inputs like branch name. For |
…ace_hub into style-bot-gh-action
|
merging! |
Following @sayakpaul's work introducing a GitHub style bot in diffusers huggingface/diffusers#10274 and this slack conversation (private), this PR moves the workflow into a GitHub Action making it a reusable workflow across other repos. For example in diffusers, the workflow will become:
Note:
pre_commit_scriptinput was added to be able to do some repo-specific steps before committing.