[chore] catch styling bugs in the prs better.#321
Open
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
commented
Mar 10, 2026
| build_toml = kernel_dir / "build.toml" | ||
| build_toml.write_text( | ||
| """[general] | ||
| build_toml.write_text("""[general] |
Member
Author
There was a problem hiding this comment.
Result of make style.
We could consider fixing the black version (same for isort and ruff) but I don't think it's a big deal.
Member
Author
|
Doesn't look like we have |
danieldk
reviewed
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, our CI doesn't properly catch the styling issues despite having the
lint.ymlworkflow. This PR fixes that.Additionally, this PR:
qualitycommand in theMakefile. So, when developers runmake style && make quality, they know that the CI will be through with this.test_kernels.ymlworkflow.