[chore] catch styling bugs in the prs better.

.github/workflows/lint.yml

@@ -1,5 +1,8 @@
-name: Lints
-on: [push, pull_request]
+name: Styling and lints
+on:
+  push:
+  pull_request:
+  workflow_call:
 jobs:
   lint:
     name: Run lints
@@ -8,8 +11,8 @@ jobs:
       - uses: actions/checkout@v6
       - name: Run ruff
         uses: astral-sh/ruff-action@v3
-        src: >-
-          kernels
+        with:
+          src: kernels/src kernels/tests
 
   black:
     name: Run black check
@@ -24,12 +27,24 @@ jobs:
         with:
           python-version: 3.12
 
-      - name: Install black
-        run: uv pip install black
-
       - name: Check formatting
-        run: |
-          uv run black --check kernels
+        run: uv run --with black black --check kernels/src kernels/tests
+
+  isort:
+    name: Run isort check
+    runs-on: ubuntu-latest
+    env:
+      UV_PYTHON_PREFERENCE: only-managed
+    steps:
+      - uses: actions/checkout@v6
+
+      - name: Install uv and set the python version
+        uses: astral-sh/setup-uv@v7
+        with:
+          python-version: 3.12
+
+      - name: Check import sorting
+        run: uv run --with isort isort --check-only --diff kernels/src kernels/tests
 
   validate-dependencies:
     name: Validate python_depends.json

.github/workflows/test_kernels.yaml

@@ -13,7 +13,11 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  styling-and-lints:
+    uses: ./.github/workflows/lint.yml
+
   build:
+    needs: [styling-and-lints]
     name: Run kernels tests
     runs-on:
       group: aws-g6-24xlarge

kernels/Makefile

@@ -1,4 +1,4 @@
-.PHONY: style
+.PHONY: style quality
 
 export check_dirs := src tests
 
@@ -11,3 +11,8 @@ style:
 	black ${check_dirs}
 	isort ${check_dirs}
 	ruff check ${check_dirs} --fix
+
+quality:
+	black --check ${check_dirs}
+	isort --check-only --diff ${check_dirs}
+	ruff check ${check_dirs}

kernels/tests/test_kernel_card.py

@@ -23,8 +23,7 @@ def mock_kernel_dir():
         kernel_dir = Path(tmpdir)
 
         build_toml = kernel_dir / "build.toml"
-        build_toml.write_text(
-            """[general]
+        build_toml.write_text("""[general]
 name = "test_kernel"
 backends = ["cuda", "metal"]
 license = "apache-2.0"
@@ -36,32 +35,27 @@ def mock_kernel_dir():
 [kernel._test]
 backend = "cuda"
 cuda-capabilities = ["8.0", "8.9"]
-"""
-        )
+""")
 
         torch_ext_dir = kernel_dir / "torch-ext" / "test_kernel"
         torch_ext_dir.mkdir(parents=True)
 
         init_file = torch_ext_dir / "__init__.py"
-        init_file.write_text(
-            """from .core import func1, func2
+        init_file.write_text("""from .core import func1, func2
 
 __all__ = ["func1", "func2", "func3"]
-"""
-        )
+""")
 
         core_file = torch_ext_dir / "core.py"
-        core_file.write_text(
-            """def func1():
+        core_file.write_text("""def func1():
     pass
 
 def func2():
     pass
 
 def func3():
     pass
-"""
-        )
+""")
 
         yield kernel_dir
 
@@ -72,17 +66,15 @@ def mock_kernel_dir_with_benchmark(mock_kernel_dir):
     benchmarks_dir.mkdir()
 
     benchmark_file = benchmarks_dir / "benchmark.py"
-    benchmark_file.write_text(
-        """import time
+    benchmark_file.write_text("""import time
 
 def benchmark():
     # Simple benchmark
     start = time.time()
     # ... benchmark code ...
     end = time.time()
     return end - start
-"""
-    )
+""")
 
     return mock_kernel_dir
 
@@ -93,12 +85,10 @@ def mock_kernel_dir_minimal():
         kernel_dir = Path(tmpdir)
 
         build_toml = kernel_dir / "build.toml"
-        build_toml.write_text(
-            """[general]
+        build_toml.write_text("""[general]
 name = "minimal_kernel"
 backends = ["cuda"]
-"""
-        )
+""")
 
         yield kernel_dir
 

kernels/tests/test_layer.py

@@ -102,7 +102,7 @@ def __init__(self):
 
     def forward(self, input: torch.Tensor) -> torch.Tensor:
         self.n_calls += 1
-        d = input.shape[-1] // 2
+        _ = input.shape[-1] // 2
         return F.relu(input)
 
 

kernels/tests/test_status.py

@@ -1,9 +1,10 @@
-import pytest
 from unittest.mock import MagicMock
 
+import pytest
+
 from kernels.status import (
-    Redirect,
     KernelStatus,
+    Redirect,
     resolve_status,
 )
 
@@ -60,7 +61,9 @@ def test_redirect(self, tmp_path):
         from huggingface_hub.utils import EntryNotFoundError
 
         status_file = tmp_path / "kernel-status.toml"
-        status_file.write_text('kind = "redirect"\ndestination = "kernels-community/new-kernel"')
+        status_file.write_text(
+            'kind = "redirect"\ndestination = "kernels-community/new-kernel"'
+        )
 
         def mock_download(repo_id, filename, revision):
             if repo_id == "kernels-test/old-kernel":
@@ -78,7 +81,9 @@ def test_redirect_with_revision(self, tmp_path):
         from huggingface_hub.utils import EntryNotFoundError
 
         status_file = tmp_path / "kernel-status.toml"
-        status_file.write_text('kind = "redirect"\ndestination = "kernels-community/new-kernel"\nrevision = "v2"')
+        status_file.write_text(
+            'kind = "redirect"\ndestination = "kernels-community/new-kernel"\nrevision = "v2"'
+        )
 
         def mock_download(repo_id, filename, revision):
             if repo_id == "kernels-test/old-kernel":