FIX SFT example (8bit quant, trl) #2857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a few issues with the examples/sft example. - There was an error in argument parsing due to trl renaming an argument to max_length, which was now conflicting with another argument name already in use. - If a user wanted to choose 8bit bnb quantization, they also had to pass use_4bit_quantization=True as an argument due to a wrong indentiation. - Documented that 8bit quantization does not work with FSDP (the aforementioned bug may have masked this)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This was referenced Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues with the
examples/sftexample.max_length, which was now conflicting with another argument name already in use.use_4bit_quantization=Trueas an argument due to a wrong indentation.I verified locally that 4bit bnb works with FSDP but 8bit raises an error (see #2833).