-
Notifications
You must be signed in to change notification settings - Fork 31k
fix chameleonvision UT failure #39646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: [email protected] <Yao Matrix>
Signed-off-by: Yao, Matrix <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
| "ChameleonVQVAEEncoderAttnBlock", | ||
| "ChameleonVQVAEEncoderResnetBlock", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! we can also put instead ChameleonVQVAEEncoder if these blocks are small enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems ChameleonVQVAEEncoder is a mega block w/ multiple ChameleonVQVAEEncoderResnetBlock, ChameleonVQVAEEncoderConvDownsample and ChameleonVQVAEEncoderAttnBlock(
| class ChameleonVQVAEEncoder(nn.Module): |
ChameleonVQVAEEncoder
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: chameleon |
* fix chameleonvision UT failure Signed-off-by: [email protected] <Yao Matrix> * fix style Signed-off-by: Yao, Matrix <[email protected]> --------- Signed-off-by: [email protected] <Yao Matrix> Signed-off-by: Yao, Matrix <[email protected]> Co-authored-by: root <Yao Matrix>
* fix chameleonvision UT failure Signed-off-by: [email protected] <Yao Matrix> * fix style Signed-off-by: Yao, Matrix <[email protected]> --------- Signed-off-by: [email protected] <Yao Matrix> Signed-off-by: Yao, Matrix <[email protected]> Co-authored-by: root <Yao Matrix>
* fix chameleonvision UT failure Signed-off-by: [email protected] <Yao Matrix> * fix style Signed-off-by: Yao, Matrix <[email protected]> --------- Signed-off-by: [email protected] <Yao Matrix> Signed-off-by: Yao, Matrix <[email protected]> Co-authored-by: root <Yao Matrix>
* fix chameleonvision UT failure Signed-off-by: [email protected] <Yao Matrix> * fix style Signed-off-by: Yao, Matrix <[email protected]> --------- Signed-off-by: [email protected] <Yao Matrix> Signed-off-by: Yao, Matrix <[email protected]> Co-authored-by: root <Yao Matrix>
* fix chameleonvision UT failure Signed-off-by: [email protected] <Yao Matrix> * fix style Signed-off-by: Yao, Matrix <[email protected]> --------- Signed-off-by: [email protected] <Yao Matrix> Signed-off-by: Yao, Matrix <[email protected]> Co-authored-by: root <Yao Matrix>
* fix chameleonvision UT failure Signed-off-by: [email protected] <Yao Matrix> * fix style Signed-off-by: Yao, Matrix <[email protected]> --------- Signed-off-by: [email protected] <Yao Matrix> Signed-off-by: Yao, Matrix <[email protected]> Co-authored-by: root <Yao Matrix>
* fix chameleonvision UT failure Signed-off-by: [email protected] <Yao Matrix> * fix style Signed-off-by: Yao, Matrix <[email protected]> --------- Signed-off-by: [email protected] <Yao Matrix> Signed-off-by: Yao, Matrix <[email protected]> Co-authored-by: root <Yao Matrix>
as discussed in huggingface/diffusers#11690, ut
pytest -rA tests/models/chameleon/test_modeling_chameleon.py::ChameleonVision2SeqModelTest::test_model_parallel_beam_searchw/ 2 cards, the error log is "RuntimeError: Expected all tensors to be on the same device, but found at least two devices,src/transformers/models/chameleon/modeling_chameleon.py", the reason is even residual is in the same device as hidden_states at the beginning, but after they went through some operators as both input and output, they finally placed to different device, but when they come to + which is not a nn.Module(so accelerate cannot pre-hook it), error happens.so, update
no_split_modulesinChameleonVQVAEto avoid it. @SunMarc, pls help review, thx.