Skip to content

fix chameleonvision UT failure #39646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 30, 2025
Merged

fix chameleonvision UT failure #39646

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9cf21a5
fix chameleonvision UT failure
Jul 24, 2025
c0ed7ed
Merge branch 'main' into ChameleonVision-fix
yao-matrix Jul 24, 2025
a5efc4b
Merge branch 'main' into ChameleonVision-fix
yao-matrix Jul 24, 2025
9260321
fix style
yao-matrix Jul 24, 2025
38f2ab7
Merge branch 'main' into ChameleonVision-fix
yao-matrix Jul 25, 2025
48fa91e
Merge branch 'main' into ChameleonVision-fix
yao-matrix Jul 25, 2025
6ea7189
Merge branch 'main' into ChameleonVision-fix
yao-matrix Jul 28, 2025
bc177a7
Merge branch 'main' into ChameleonVision-fix
yao-matrix Jul 28, 2025
500e26a
Merge branch 'main' into ChameleonVision-fix
yao-matrix Jul 29, 2025
95ada3e
Merge branch 'main' into ChameleonVision-fix
yao-matrix Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/transformers/models/chameleon/modeling_chameleon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,11 @@ class ChameleonPreTrainedModel(PreTrainedModel):
)
class ChameleonVQVAE(ChameleonPreTrainedModel):
config: ChameleonVQVAEConfig
_no_split_modules = ["ChameleonVQVAEVectorQuantizer"]
_no_split_modules = [
"ChameleonVQVAEVectorQuantizer",
"ChameleonVQVAEEncoderAttnBlock",
"ChameleonVQVAEEncoderResnetBlock",
Comment on lines +822 to +823
Copy link
Member

@SunMarc SunMarc Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! we can also put instead ChameleonVQVAEEncoder if these blocks are small enough

Copy link
Contributor Author

@yao-matrix yao-matrix Jul 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ChameleonVQVAEEncoder is a mega block w/ multiple ChameleonVQVAEEncoderResnetBlock, ChameleonVQVAEEncoderConvDownsample and ChameleonVQVAEEncoderAttnBlock(

transformers/src/transformers/models/chameleon/modeling_chameleon.py

Line 650 in 4abb053

class ChameleonVQVAEEncoder(nn.Module):
), so maybe better not to put ChameleonVQVAEEncoder

]

def __init__(self, config: ChameleonVQVAEConfig):
super().__init__(config)
Expand Down