fix: Correct Switch Transformers sparse layer logic and outdated spectrogram comment #43336
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The following issues were identified and fixed in this PR:
SwitchTransformersConfigincorrectly created sparse (MoE) layers whennum_sparse_encoder_layers=0andnum_layers=1due to prev logic. The modeling code’ssparse_step == 1condition would then trigger, creating a sparse layer when none were requested. This is fixed by settingencoder_sparse_step = 0anddecoder_sparse_step = 0when no sparse layers are requested, which the modeling code already handles correctly viaif sparse_step > 0 else False.audio_utils.pythat statedspectrogram()does not support batching, even thoughspectrogram_batch()already exists. Changed to a note referencing the batch function.Fixes #43335.
Before submitting
Pull Request section?
to it if that's the case.
[documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
[here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
cc: @Rocketknight1