generated from fastai/nbdev_template
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add Nemotron 3 to tests via tiny model #5278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sergiopaniego
wants to merge
9
commits into
main
Choose a base branch
from
nemotron3-tiny-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−1
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
dd4f3a6
Add Nemotron 3 to tests via tiny model
sergiopaniego 529ef04
Code quality
sergiopaniego 875a46c
Merge branch 'main' into nemotron3-tiny-tests
sergiopaniego b79861f
Updated
sergiopaniego 27cef67
Merge branch 'nemotron3-tiny-tests' of github.com:huggingface/trl int…
sergiopaniego 4f9b1f8
Update
sergiopaniego 8122d6d
Merge branch 'main' into nemotron3-tiny-tests
sergiopaniego c555040
Update
sergiopaniego 3c8f9d4
Cursor review
sergiopaniego File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -171,17 +171,33 @@ class TestDPOTrainer(TrlTestCase): | |
| "trl-internal-testing/tiny-Qwen2ForCausalLM-2.5", | ||
| "trl-internal-testing/tiny-Qwen3MoeForCausalLM", | ||
| "trl-internal-testing/tiny-GptOssForCausalLM", | ||
| pytest.param( | ||
| "trl-internal-testing/tiny-NemotronHForCausalLM", | ||
| marks=pytest.mark.skipif( | ||
| Version(transformers.__version__) < Version("5.3.0"), | ||
| reason="NemotronH models were introduced in transformers-5.3.0", | ||
| ), | ||
| ), | ||
| ], | ||
| ) | ||
| def test_train(self, model_id): | ||
| # Get the dataset | ||
| dataset = load_dataset("trl-internal-testing/zen", "standard_preference", split="train") | ||
|
|
||
| # NemotronH (hybrid Mamba-Attention) does not support gradient checkpointing. The Mamba CUDA | ||
| # kernels require strides to be multiples of 8, which is incompatible with tiny model dimensions. | ||
| # Force CPU so that the model uses the pure PyTorch path (works fine on GPU without kernels). | ||
| kwargs = {} | ||
| if "NemotronH" in model_id: | ||
| kwargs["gradient_checkpointing"] = False | ||
| kwargs["use_cpu"] = True | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. really not sure about this. we don't train on cpu, so why testing it + we wouldn't know it a gpu-specific issue is introduced |
||
|
|
||
| # Initialize the trainer | ||
| training_args = DPOConfig( | ||
| output_dir=self.tmp_dir, | ||
| learning_rate=0.1, # use higher lr because gradients are tiny and default lr can stall updates | ||
| report_to="none", | ||
| **kwargs, | ||
| ) | ||
| trainer = DPOTrainer(model=model_id, args=training_args, train_dataset=dataset) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you cast
backbone.layers.[N].mixer.Dandbackbone.layers.[N].mixer.A_logto fp32?: it seems like these two layers are in fp32, and we want to be as close as possible to the reference modelcheck how we do here for Qwen3.5 https://github.com/huggingface/trl/pull/5278/changes#diff-dd3349f840a26de373fc88378e6fcded0b75423da8a34f7cfa6ac573b7398b8bL404