Skip to content

Comments

rollback latest to v0.5.1#92

Merged
dexhorthy merged 1 commit intohumanlayer:mainfrom
dexhorthy:rollback-v0.5.1
May 12, 2025
Merged

rollback latest to v0.5.1#92
dexhorthy merged 1 commit intohumanlayer:mainfrom
dexhorthy:rollback-v0.5.1

Conversation

@dexhorthy
Copy link
Contributor

@dexhorthy dexhorthy commented May 12, 2025

Important

Rollback configuration files to v0.5.1, removing specific properties and changing image version.

  • Rollback:
    • Revert acp/config/release/latest-crd.yaml and acp/config/release/latest.yaml to v0.5.1.
    • Remove properties description, subAgents, validSubAgents, contextWindow, and Agent from latest-crd.yaml and latest.yaml.
    • Change image version in Deployment to v0.5.1 in latest.yaml.
  • Misc:
    • Remove acp-controller-manager-api-service from latest.yaml.

This description was created by Ellipsis for 82c91ec. You can customize this summary. It will automatically update as commits are pushed.

@dexhorthy dexhorthy merged commit 1d9b06e into humanlayer:main May 12, 2025
4 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 82c91ec in 1 minute and 5 seconds. Click for details.
  • Reviewed 352 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. acp/config/release/latest-crd.yaml:50
  • Draft comment:
    Removed Agent 'description' field. Confirm no tooling depends on it.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm that no tooling depends on the removed field. This falls under the rule of not asking the author to confirm their intention or to double-check things. Therefore, this comment should be removed.
2. acp/config/release/latest-crd.yaml:70
  • Draft comment:
    Removed 'subAgents' and 'validSubAgents' from AgentSpec. Verify backward compatibility.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. acp/config/release/latest-crd.yaml:840
  • Draft comment:
    Removed 'contextWindow' property from Task spec. Ensure no needed functionality is lost.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. acp/config/release/latest-crd.yaml:860
  • Draft comment:
    Added minLength:1 to 'userMessage' and made it required. Confirm existing tasks meet this.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. acp/config/release/latest.yaml:1615
  • Draft comment:
    Rolled back container image to v0.5.1. Ensure controller and CRDs remain in sync.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure that the controller and CRDs remain in sync after rolling back the container image. This falls under the category of asking the author to ensure something, which is against the rules.
6. acp/config/release/latest.yaml:1623
  • Draft comment:
    Set container 'ports' to empty array. Verify v0.5.1 does not rely on an API port.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify something about a specific version, which is not allowed according to the rules. It doesn't provide a specific suggestion or point out a clear issue with the code.

Workflow ID: wflow_YGSztjum1pQi0exo

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant