Conversation
husarafal
approved these changes
Nov 6, 2025
| declare_robot_model_arg, | ||
| declare_mecanum_arg, # mecanum base on robot_model arg | ||
| declare_controller_config_arg, # controler_config base on mecanum and robot_model arg | ||
| declare_config_dir_arg, # controler_config base on mecanum and robot_model arg |
Contributor
There was a problem hiding this comment.
Suggested change
| declare_config_dir_arg, # controler_config base on mecanum and robot_model arg | |
| declare_config_dir_arg, # controller_config base on mecanum and robot_model arg |
Contributor
Author
There was a problem hiding this comment.
The default value do not depend on mecanum and robot_model, so I order it alphabetically
| config_rosbot_description_dir, "config", robot_model, components_file | ||
| ) | ||
|
|
||
| if robot_model != "rosbot_xl" and configuration != "basic": |
Contributor
There was a problem hiding this comment.
Disallows custom config for base rosbot model, even though this PR introduces rosbot_description/config/rosbot/custom.yaml.
Co-authored-by: husarafal <rafal.zelazko@husarion.com>
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin humble
git worktree add -d .worktree/backport-149-to-humble origin/humble
cd .worktree/backport-149-to-humble
git switch --create backport-149-to-humble
git cherry-pick -x 866fbae410974e0d349680545517136186e2f323 |
rafal-gorecki
added a commit
that referenced
this pull request
Nov 6, 2025
rafal-gorecki
added a commit
that referenced
this pull request
Nov 6, 2025
rafal-gorecki
added a commit
that referenced
this pull request
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump::minor
create_config_dir.pyfor creating a configuration folder has also been added.