Open
Conversation
Contributor
huttongrabiel
left a comment
huttongrabiel
left a comment
There was a problem hiding this comment.
Really good! Just a couple minor things
huttongrabiel
requested changes
Nov 8, 2024
Contributor
huttongrabiel
left a comment
huttongrabiel
left a comment
There was a problem hiding this comment.
Nice! Just a few things to fix
huttongrabiel
requested changes
Nov 19, 2024
huttongrabiel
requested changes
Mar 4, 2025
src/TunePID.cpp
Outdated
| enum class targetmode_t { | ||
| step, sinusoidal | ||
| enum class targetmode_t | ||
| { |
Contributor
There was a problem hiding this comment.
can you move this onto the same line enum class targetmode_t? i thought clang-format would catch this but ig not
Author
There was a problem hiding this comment.
so should it be like enum class targetmode_t {step, sinusoidal}; ?
Author
There was a problem hiding this comment.
Oh you meant the left bracket?
Contributor
There was a problem hiding this comment.
i want it to be like
enum class targetmode_t {
step,
sinusoidal
};but maybe that isn't what clang-format wants
src/TunePID.cpp
Outdated
| prescaled_target = round(prescaled_target); | ||
| } | ||
| angle_target = (int32_t) round(amplitude * prescaled_target) + starting_angle; | ||
| angle_target = (int32_t)round(amplitude * prescaled_target) + starting_angle; |
Contributor
There was a problem hiding this comment.
Can you use a static_cast instead of a C-style cast?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.