f/690 - Wrote pressure_sensor node #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonard-pak
requested changes
Nov 16, 2025
src/wika_pressure_sensor/include/wika_pressure_sensor/wika_sensor_node.hpp
Outdated
Show resolved
Hide resolved
src/wika_pressure_sensor/include/wika_pressure_sensor/wika_sensor_node.hpp
Outdated
Show resolved
Hide resolved
WaspishRaccoon
changed the title
WaspishRaccoon
force-pushed
the
f/690-Develop_wika_sensor_node
branch
from
346b003 to
85d70bc
Compare
leonard-pak
requested changes
Dec 13, 2025
There was a problem hiding this comment.
давай попробуем переписать на ament_auto https://github.com/ament/ament_cmake/tree/humble/ament_cmake_auto
There was a problem hiding this comment.
в конце нет пробела, надо добавить. и настроить форматер, он такое сам будет исправлять
Member
Author
There was a problem hiding this comment.
Не очень понял, на что ты ссылаешься
src/pressure_sensor/include/pressure_sensor/pressure_sensor_impl.hpp
Outdated
Show resolved
Hide resolved
src/pressure_sensor/include/pressure_sensor/pressure_sensor_impl.hpp
Outdated
Show resolved
Hide resolved
src/pressure_sensor/include/pressure_sensor/pressure_sensor.hpp
Outdated
Show resolved
Hide resolved
Comment on lines
16
to
21
| rclcpp::node_interfaces::NodeBaseInterface::SharedPtr | ||
| get_node_base_interface() { | ||
| return node_->get_node_base_interface(); | ||
| } | ||
|
|
||
| rclcpp::Logger get_logger() const { return node_->get_logger(); } |
There was a problem hiding this comment.
Очень похоже, что мы такое можем вынести в общею библиотеку по типу stingray_base_cpp и там создать интерфейс INodeWrapper, который и будет создавать ноду и предоставлять эти методы
З.Ы. get_logger нигде не используется
This was referenced Dec 13, 2025
leonard-pak
requested changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.