Skip to content

refactor!: remove unused activityWeight definition#95

Closed
bitbeckers wants to merge 1 commit intodevelopfrom
fix/remove_activity_weight
Closed

refactor!: remove unused activityWeight definition#95
bitbeckers wants to merge 1 commit intodevelopfrom
fix/remove_activity_weight

Conversation

@bitbeckers
Copy link
Contributor

@bitbeckers bitbeckers commented Jan 21, 2026

BREAKING CHANGE: activityWeight definition has been removed from org.hypercerts.claim.activity lexicon. This definition was not being used anywhere in the codebase.

The activityWeight type (which contained activity strongRef and weight fields) was a leftover from an earlier design and is no longer needed.

Changes:

  • Remove activityWeight definition from activity lexicon defs
  • Remove activityWeight documentation from README.md
  • Add changeset for version bump

Closes #84

Summary by CodeRabbit

  • Chores
    • Removed unused activityWeight definition from the activity lexicon schema and updated related documentation.

✏️ Tip: You can customize this high-level summary in your review settings.

BREAKING CHANGE: activityWeight definition has been removed from
org.hypercerts.claim.activity lexicon. This definition was not being
used anywhere in the codebase.

The activityWeight type (which contained activity strongRef and weight
fields) was a leftover from an earlier design and is no longer needed.

Changes:
- Remove activityWeight definition from activity lexicon defs
- Remove activityWeight documentation from README.md
- Add changeset for version bump
@bitbeckers bitbeckers requested a review from aspiers January 21, 2026 00:45
@bitbeckers bitbeckers self-assigned this Jan 21, 2026
@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2026

🦋 Changeset detected

Latest commit: c2bf781

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hypercerts-org/lexicon Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

The PR removes the unused activityWeight definition from the Hypercerts activity lexicon schema to reduce complexity. Changes include deletion of the definition from the lexicon file, corresponding documentation updates, and a changelog entry documenting the minor version change.

Changes

Cohort / File(s) Summary
Schema definition removal
lexicons/org/hypercerts/claim/activity.json
Removed the activityWeight object definition from the defs section, eliminating the public entity that previously declared required activity and weight fields.
Documentation cleanup
README.md
Removed references to and descriptions of the activityWeight definition from two documentation sections covering the Hypercerts Activity Claim lexicon.
Changelog entry
.changeset/remove-activity-weight.md
Added a changeset documenting a minor version bump for the lexicon package with a summary of the activityWeight removal.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • aspiers
  • holkexyz
  • s-adamantine

Poem

🐰 A weight once carried by activities dear,
Now gently removed—no longer needed here,
The schema grows lighter, more clean and refined,
Unused definitions left far behind! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'refactor!: remove unused activityWeight definition' directly and clearly describes the main change—removing an unused definition from the activity lexicon, matching the core objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Lexicon Documentation Sync ✅ Passed PR successfully maintains synchronization between JSON lexicons, README documentation, and ERD.puml with activityWeight completely removed from all locations.
Lexicons Styleguide Compliance ✅ Passed The lexicon file maintains valid JSON schema structure with all required ATProto fields (type, id, defs, revision) and follows repository naming conventions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aspiers
Copy link
Contributor

aspiers commented Jan 21, 2026

Superseded by #102.

@aspiers aspiers closed this Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove activityWeight from activity claim

2 participants