Skip to content

refactor!: remove unused activityWeight definition #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bitbeckers wants to merge 1 commit into from
Closed

refactor!: remove unused activityWeight definition #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/remove-activity-weight.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hypercerts-org/lexicon": minor
---

Remove unused activityWeight definition from activity lexicon. This definition was not being used anywhere in the codebase and has been removed to simplify the schema.
9 changes: 0 additions & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,15 +300,6 @@ Hypercerts-specific lexicons for tracking impact work and claims.
| `locations` | `ref` | ❌ | An array of strong references to the locations where the work for done hypercert was located | References must conform to `app.certified.location` |
| `createdAt` | `string` | ✅ | Client-declared timestamp when this record was originally created | |

#### Defs

##### activityWeight

| Property | Type | Required | Description |
| ---------- | -------- | -------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `activity` | `ref` | ✅ | A strong reference to a hypercert activity record. This activity must conform to the lexicon org.hypercerts.claim.activity |
| `weight` | `string` | ✅ | The relative weight/importance of this hypercert activity (stored as a string to avoid float precision issues). Weights can be any positive numeric values and do not need to sum to a specific total; normalization can be performed by the consuming application as needed. |

---

### Hypercerts Contribution
Expand Down
15 changes: 0 additions & 15 deletions lexicons/org/hypercerts/claim/activity.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,21 +107,6 @@
"maxLength": 100
}
}
},
"activityWeight": {
"type": "object",
"required": ["activity", "weight"],
"properties": {
"activity": {
"type": "ref",
"ref": "com.atproto.repo.strongRef",
"description": "A strong reference to a hypercert activity record. This activity must conform to the lexicon org.hypercerts.claim.activity"
},
"weight": {
"type": "string",
"description": "The relative weight/importance of this hypercert activity (stored as a string to avoid float precision issues). Weights can be any positive numeric values and do not need to sum to a specific total; normalization can be performed by the consuming application as needed."
}
}
}
}
}