Skip to content

Conversation

@pulpdrew
Copy link
Contributor

@pulpdrew pulpdrew commented Oct 16, 2025

This PR fixes the following warnings from our unit tests, which were cluttering up the output:

  • The regex warning is fixed by removing the /g global flag from element selectors
  • The deprecation warning is fixed by the package upgrade
Screenshot 2025-10-16 at 9 06 57 AM Screenshot 2025-10-16 at 9 06 50 AM

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2025

⚠️ No Changeset found

Latest commit: 2392005

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Oct 16, 2025 4:48pm

@claude
Copy link

claude bot commented Oct 16, 2025

Code Review

No critical issues found.

Summary

The changes correctly address test warnings:

  • Regex fix: Removed /g global flag from getAllByTestId() calls - the Testing Library query methods expect a plain regex matcher, not a global regex
  • Dependency upgrade: @testing-library/react 14→16 and @testing-library/dom 10.4.1 added as explicit dependency to resolve deprecation warnings

Verification

  • All 7 instances of the problematic pattern fixed in DBSearchPageFilters.test.tsx
  • No other files in the codebase use this incorrect pattern
  • Package upgrade follows proper peer dependency requirements (adds @testing-library/dom as peer)
  • Changes are backward compatible with existing test patterns

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

E2E Test Results

All tests passed • 25 passed • 3 skipped • 224s

Status Count
✅ Passed 25
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

Comment on lines +120 to +122
"@testing-library/dom": "^10.4.1",
"@testing-library/jest-dom": "^6.4.2",
"@testing-library/react": "^14.2.1",
"@testing-library/react": "^16.3.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v16 of @testing-library/react requires @testing-library/dom as peer dependency.

@pulpdrew pulpdrew requested review from a team and dhable and removed request for a team October 16, 2025 13:58
@kodiakhq kodiakhq bot merged commit 4cfbd75 into main Oct 16, 2025
9 checks passed
@kodiakhq kodiakhq bot deleted the drew/fix-test-warnings branch October 16, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants