-
Notifications
You must be signed in to change notification settings - Fork 347
chore: Cleanup warnings in unit tests #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code Review✅ No critical issues found. SummaryThe changes correctly address test warnings:
Verification
LGTM ✓ |
E2E Test Results✅ All tests passed • 25 passed • 3 skipped • 224s
|
25f8e68 to
4575cff
Compare
| "@testing-library/dom": "^10.4.1", | ||
| "@testing-library/jest-dom": "^6.4.2", | ||
| "@testing-library/react": "^14.2.1", | ||
| "@testing-library/react": "^16.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v16 of @testing-library/react requires @testing-library/dom as peer dependency.
This PR fixes the following warnings from our unit tests, which were cluttering up the output: