Skip to content

chore: Cleanup warnings in unit tests #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Oct 16, 2025
Merged

chore: Cleanup warnings in unit tests #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4575cff
chore: Cleanup warnings in unit tests
pulpdrew Oct 16, 2025
2392005
Merge branch 'main' into drew/fix-test-warnings
kodiakhq[bot] Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,9 @@
"@storybook/nextjs": "^8.1.5",
"@storybook/react": "^8.1.5",
"@storybook/test": "^8.1.5",
"@testing-library/dom": "^10.4.1",
"@testing-library/jest-dom": "^6.4.2",
"@testing-library/react": "^14.2.1",
"@testing-library/react": "^16.3.0",
Comment on lines +120 to +122
Copy link
Contributor Author

@pulpdrew pulpdrew Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v16 of @testing-library/react requires @testing-library/dom as peer dependency.

"@testing-library/user-event": "^14.5.2",
"@types/crypto-js": "^4",
"@types/identity-obj-proxy": "^3",
Expand Down
14 changes: 7 additions & 7 deletions packages/app/src/components/__tests__/DBSearchPageFilters.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ describe('FilterGroup', () => {
it('should sort options alphabetically by default', () => {
renderWithMantine(<FilterGroup {...defaultProps} />);

const options = screen.getAllByTestId(/filter-checkbox-input/g);
const options = screen.getAllByTestId(/filter-checkbox-input/);
expect(options).toHaveLength(3);
const labels = screen.getAllByText(/apple|banana|zebra/);
expect(labels[0]).toHaveTextContent('apple');
Expand All @@ -247,7 +247,7 @@ describe('FilterGroup', () => {
/>,
);

const options = screen.getAllByTestId(/filter-checkbox-input/g);
const options = screen.getAllByTestId(/filter-checkbox-input/);
expect(options).toHaveLength(3);
const labels = screen.getAllByText(/apple|banana|zebra/);
expect(labels[0]).toHaveTextContent('apple');
Expand Down Expand Up @@ -276,7 +276,7 @@ describe('FilterGroup', () => {
/>,
);

const options = screen.getAllByTestId(/filter-checkbox-input/g);
const options = screen.getAllByTestId(/filter-checkbox-input/);
expect(options).toHaveLength(3);
const labels = screen.getAllByText(/apple|banana|zebra/);
expect(labels[0]).toHaveTextContent('banana'); // Selected
Expand Down Expand Up @@ -309,7 +309,7 @@ describe('FilterGroup', () => {
);
await userEvent.click(showPercentages);

const options = screen.getAllByTestId(/filter-checkbox-input/g);
const options = screen.getAllByTestId(/filter-checkbox-input/);
expect(options).toHaveLength(3);
const labels = screen.getAllByText(/%/);
expect(labels[0]).toHaveTextContent('~99%'); // apple
Expand All @@ -328,7 +328,7 @@ describe('FilterGroup', () => {
/>,
);

const options = screen.getAllByTestId(/filter-checkbox-input/g);
const options = screen.getAllByTestId(/filter-checkbox-input/);
expect(options).toHaveLength(3);
const labels = screen.getAllByText(/apple|banana|zebra/);
expect(labels[0]).toHaveTextContent('apple'); // included first
Expand Down Expand Up @@ -359,7 +359,7 @@ describe('FilterGroup', () => {
);

// Should show MAX_FILTER_GROUP_ITEMS (10) by default
let options = screen.getAllByTestId(/filter-checkbox-input/g);
let options = screen.getAllByTestId(/filter-checkbox-input/);
expect(options).toHaveLength(10);

// Selected items should be visible even if they would be beyond MAX_FILTER_GROUP_ITEMS
Expand All @@ -372,7 +372,7 @@ describe('FilterGroup', () => {
await userEvent.click(showMoreButton);

// Should show all items
options = screen.getAllByTestId(/filter-checkbox-input/g);
options = screen.getAllByTestId(/filter-checkbox-input/);
expect(options).toHaveLength(15);
});

Expand Down
59 changes: 41 additions & 18 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4589,8 +4589,9 @@ __metadata:
"@tanstack/react-query-devtools": "npm:^5.56.2"
"@tanstack/react-table": "npm:^8.7.9"
"@tanstack/react-virtual": "npm:^3.0.1"
"@testing-library/dom": "npm:^10.4.1"
"@testing-library/jest-dom": "npm:^6.4.2"
"@testing-library/react": "npm:^14.2.1"
"@testing-library/react": "npm:^16.3.0"
"@testing-library/user-event": "npm:^14.5.2"
"@types/crypto-js": "npm:^4"
"@types/identity-obj-proxy": "npm:^3"
Expand Down Expand Up @@ -9467,7 +9468,23 @@ __metadata:
languageName: node
linkType: hard

"@testing-library/dom@npm:^9.0.0, @testing-library/dom@npm:^9.3.4":
"@testing-library/dom@npm:^10.4.1":
version: 10.4.1
resolution: "@testing-library/dom@npm:10.4.1"
dependencies:
"@babel/code-frame": "npm:^7.10.4"
"@babel/runtime": "npm:^7.12.5"
"@types/aria-query": "npm:^5.0.1"
aria-query: "npm:5.3.0"
dom-accessibility-api: "npm:^0.5.9"
lz-string: "npm:^1.5.0"
picocolors: "npm:1.1.1"
pretty-format: "npm:^27.0.2"
checksum: 10c0/19ce048012d395ad0468b0dbcc4d0911f6f9e39464d7a8464a587b29707eed5482000dad728f5acc4ed314d2f4d54f34982999a114d2404f36d048278db815b1
languageName: node
linkType: hard

"@testing-library/dom@npm:^9.3.4":
version: 9.3.4
resolution: "@testing-library/dom@npm:9.3.4"
dependencies:
Expand Down Expand Up @@ -9516,17 +9533,23 @@ __metadata:
languageName: node
linkType: hard

"@testing-library/react@npm:^14.2.1":
version: 14.2.1
resolution: "@testing-library/react@npm:14.2.1"
"@testing-library/react@npm:^16.3.0":
version: 16.3.0
resolution: "@testing-library/react@npm:16.3.0"
dependencies:
"@babel/runtime": "npm:^7.12.5"
"@testing-library/dom": "npm:^9.0.0"
"@types/react-dom": "npm:^18.0.0"
peerDependencies:
react: ^18.0.0
react-dom: ^18.0.0
checksum: 10c0/83b35cf8bf5640f1b63b32223ebc75799dc1a8e034d819120b26838fba0b0ab10bdbe6ad07dd8ae8287365f2b0c52dc9892a6fa11bb24d3e63ad97dfb7f2f296
"@testing-library/dom": ^10.0.0
"@types/react": ^18.0.0 || ^19.0.0
"@types/react-dom": ^18.0.0 || ^19.0.0
react: ^18.0.0 || ^19.0.0
react-dom: ^18.0.0 || ^19.0.0
peerDependenciesMeta:
"@types/react":
optional: true
"@types/react-dom":
optional: true
checksum: 10c0/3a2cb1f87c9a67e1ebbbcfd99b94b01e496fc35147be8bc5d8bf07a699c7d523a09d57ef2f7b1d91afccd1a28e21eda3b00d80187fbb51b1de01e422592d845e
languageName: node
linkType: hard

Expand Down Expand Up @@ -11860,7 +11883,7 @@ __metadata:
languageName: node
linkType: hard

"aria-query@npm:^5.3.0":
"aria-query@npm:5.3.0, aria-query@npm:^5.3.0":
version: 5.3.0
resolution: "aria-query@npm:5.3.0"
dependencies:
Expand Down Expand Up @@ -23538,6 +23561,13 @@ __metadata:
languageName: node
linkType: hard

"picocolors@npm:1.1.1, picocolors@npm:^1.1.1":
version: 1.1.1
resolution: "picocolors@npm:1.1.1"
checksum: 10c0/e2e3e8170ab9d7c7421969adaa7e1b31434f789afb9b3f115f6b96d91945041ac3ceb02e9ec6fe6510ff036bcc0bf91e69a1772edc0b707e12b19c0f2d6bcf58
languageName: node
linkType: hard

"picocolors@npm:^1.0.0":
version: 1.0.0
resolution: "picocolors@npm:1.0.0"
Expand All @@ -23552,13 +23582,6 @@ __metadata:
languageName: node
linkType: hard

"picocolors@npm:^1.1.1":
version: 1.1.1
resolution: "picocolors@npm:1.1.1"
checksum: 10c0/e2e3e8170ab9d7c7421969adaa7e1b31434f789afb9b3f115f6b96d91945041ac3ceb02e9ec6fe6510ff036bcc0bf91e69a1772edc0b707e12b19c0f2d6bcf58
languageName: node
linkType: hard

"picomatch@npm:4.0.2, picomatch@npm:^4.0.1, picomatch@npm:^4.0.2":
version: 4.0.2
resolution: "picomatch@npm:4.0.2"
Expand Down
Loading