Remove @ts-nocheck from frontend files to ensure app is fully typechecked

[brandon-pereira]

Noticed some errors during runtime testing of another PR that should have been caught by typescript. This fixes reduces the chances of that slipping through CI

[changeset-bot]

⚠️ No Changeset found

Latest commit: a49d2a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
hyperdx-v2-oss-app	Ready	Preview, Comment	Dec 29, 2025 5:15pm

[claude]

Code Review

✅ No critical issues found.

Summary

This PR successfully removes @ts-nocheck directives from 4 frontend files and adds proper TypeScript typing. The changes are well-structured and improve type safety:

• ✅ AuthPage.tsx: Proper HTTPError type checking added, unused import removed
• ✅ LandingHeader.tsx: Clean @ts-nocheck removal
• ✅ Spotlights.tsx: Correctly uses id property (from SavedSearch schema) instead of _id, unused imports removed
• ✅ api.ts: Proper type annotations added to useDashboards and useRegisterPassword

All type changes align with existing schemas (SavedSearchSchema uses id, Dashboard type uses id). No runtime behavior changes.

[github-actions]

E2E Test Results

✅ All tests passed • 50 passed • 4 skipped • 697s

Status	Count
✅ Passed	50
❌ Failed	0
⚠️ Flaky	1
⏭️ Skipped	4

Tests ran across 4 shards in parallel.

View full report →

[pulpdrew]

LGTM