-
Notifications
You must be signed in to change notification settings - Fork 20
Make BlockListener a public package for re-use
#180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
peterbroadhurst
wants to merge
14
commits into
main
Choose a base branch
from
standalone-blocklistener
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <[email protected]>
… manage Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
BlockListener a public package for re-use
…ion checking more intuitive Signed-off-by: Peter Broadhurst <[email protected]>
4f4cab8 to
2571505
Compare
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
5e9b30f to
eeb5b99
Compare
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls the
BlockListenerout into a separate package for re-use, as part of indexing workflows.This is a useful utility that tracks the head of an Ethereum chain, and keeps an in-memory canonical chain that extends back a pre-set number of "unstable" blocks (say 100).
If any changes are detected in this head, then the consumer is notified not just of the block, but of the consistent set of blocks ahead of that up to the new head. By processing this set of hashes as a single unit, rather than many individual events, logic that deals with confirmation management is able to be optimized.
The utility also allows multiple consumers within a single go process, to share a single stream of these changes.
Breakdown of proposed change
pkgdir tofirelfy-evmconnectethblocklistenerpackage available thereetherrorsandethrpcpackages alongside for the core JSON/RPC data types and error mapping codeJSONFormatOptionstoethrpcso those structures can be serialized in more app friendly waysabi.Serializerinfirefly-signer