Add a check for dependabot PR updating guest or common lib dependencies #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongdavies
added
the
area/dependencies
dblnz
approved these changes
Jan 22, 2025
|
I suspect if we add the directory of simpleguest to dependabot.yml, it would update those cargo.toml as well, and we should be fine. It might be an easier solution that this. I'm thinking replace - package-ecosystem: "cargo"
directory: "/"
schedule:
interval: "daily"with - package-ecosystem: "cargo"
directory: ["/", "src/tests/rust_guests/simpleguest"]
schedule:
interval: "daily"It might be worth a try anyway? |
Yes , definitely, I will close this one and open a new one with your suggestion, if it doesnt work we can aways re-open this |
simongdavies
force-pushed
the
update-PR-workflow
branch
from
663a4ba to
7e8a0fa
Compare
ludfjig
approved these changes
Jan 30, 2025
Signed-off-by: Simon Davies <[email protected]>
simongdavies
force-pushed
the
update-PR-workflow
branch
from
7e8a0fa to
9fa91ae
Compare
This was referenced Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a check in the PR workflow to ensure that Cargo.lock files are up to date as a part of any PR. This works fine for most scenarios but when dependabot updates depdendencies in either
hyperlight_commonorhyperlight_guestthis may make the Cargo.lock file out of date for thesimpleguestandcallbackguesttest guest binaries.See #148 for an example of this.
This PR updates the PR workflow to update those files if there are dependabot changes to the dependencies in either of those crates.