Skip to content

Update rust to 1.89 #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 15, 2025
Merged

Update rust to 1.89 #883

merged 6 commits into from
Sep 15, 2025

Conversation

simongdavies
Copy link
Contributor

No description provided.

@simongdavies simongdavies added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Sep 11, 2025
ludfjig
ludfjig reviewed Sep 11, 2025
View reviewed changes
jprendes
jprendes reviewed Sep 11, 2025
View reviewed changes
jsturtevant
jsturtevant reviewed Sep 11, 2025
View reviewed changes
ludfjig
ludfjig reviewed Sep 12, 2025
View reviewed changes
ludfjig
ludfjig previously approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@ludfjig ludfjig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the one comment I put

nit: we have a bunch of other allow specified for the entire flatbuffer mod in src/hyperlight_common/src/lib.rs. Maybe consider moving this allow over there so it won't be removed next time we regenerate these.

@simongdavies simongdavies merged commit 6a68f85 into hyperlight-dev:main Sep 15, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jprendes jprendes jprendes left review comments

@jsturtevant jsturtevant jsturtevant approved these changes

@ludfjig ludfjig ludfjig left review comments

@danbugs danbugs Awaiting requested review from danbugs danbugs is a code owner

@dblnz dblnz Awaiting requested review from dblnz dblnz is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically is a code owner

@marosset marosset Awaiting requested review from marosset marosset is a code owner

Assignees

No one assigned

Labels

kind/enhancement For PRs adding features, improving functionality, docs, tests, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simongdavies @jsturtevant @jprendes @ludfjig