This repository was archived by the owner on Sep 11, 2025. It is now read-only.
fix: improve Go version handling #660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the Modus Runtime uses Go 1.23.4, but other projects are targeting Go 1.23.0. This should only be the case for the shared libraries in
/lib, because Go 1.23.1 fixed several security-related issues with CVEs. Instead, we should do the following:/libshould continue to target Go 1.23.0 for compatibility. (The consuming app will set the actual Go version used.)modus new, after validating that the minimum Go version is met, the CLI should set the version in the created project'sgo.modfile to the version actually installed. For example, if I have Go 1.23.2,modus newshould make me a project with1.23.2- even if the version in the template is lower or if there's a higher version available. This mirrors the behavior ofgo mod initfor regular Go projects.This PR implements these changes.
Checklist
CHANGELOG.mdfile describing and linking to this PR