fix: implement ${{ inputs.repo }} with --repoUrl#42
Merged
Anmol1696 merged 1 commit intohyperweb-io:mainfrom May 25, 2025
Merged
fix: implement ${{ inputs.repo }} with --repoUrl#42Anmol1696 merged 1 commit intohyperweb-io:mainfrom
${{ inputs.repo }} with --repoUrl#42Anmol1696 merged 1 commit intohyperweb-io:mainfrom
Conversation
michaelfig
added a commit
to agoric-labs/starship-action
that referenced
this pull request
May 28, 2025
The `test.yaml` workflow was using `inputs.name`, but it only worked because the `name` input was not defined in the `starship-action`. When `inputs.name` support was implemented in PR hyperweb-io#42, it broke the `test.yaml` workflow because the `starship stop --name` setting overrode the `config.yml` `name:` value. This installed the Helm release with a different name than what was being stopped. Without stopping the correct Helm release, `starship stop` would hang indefinitely. Now it doesn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
${{ inputs.repo }}wasn't actually passed through tostarship setup.While getting to know the
@starship/cli, I found that what was documented in theREADME.mdas--helmRepoUrlwas actually just--repoUrl. That was useful to know for fixing this issue.