Skip to content

Conversation

@jezekra1
Copy link
Collaborator

Summary

Linked Issues

Documentation

  • No Docs Needed:

If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 12, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jezekra1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces several minor yet impactful improvements across the server's agent definitions, documentation, and development environment configuration. It streamlines the naming of a core agent, enhances the clarity of observability setup for custom agents, and refines the local development experience by automating the agent registry configuration based on the latest release, while also simplifying task dependencies.

Highlights

  • Agent Renaming: The ChatV2 agent has been renamed to Chat in the agent.py file for a more concise identifier.
  • Observability Documentation Update: New documentation has been added to observability.mdx providing clear instructions and a code example on how to enable instrumentation for custom agents built with the Python SDK.
  • Dynamic Agent Registry Configuration: The tasks.toml configuration now dynamically determines the latest release tag from the git repository and sets the AGENTSTACK__AGENT_REGISTRY environment variable to point to the agent-registry.yaml of that latest tag, unless an external registry is explicitly provided.
  • Task Dependency Streamlining: Explicit build dependencies for agentstack-server and supergateway have been removed from the agentstack:start task in tasks.toml, simplifying the task definition.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces minor improvements, including renaming the chat agent and updating documentation. My review focuses on the changes in tasks.toml. I've identified a potential issue with how the latest git tag is determined, which could lead to using an outdated agent version. I've also noted the removal of task dependencies which might affect the developer workflow. I've provided suggestions to address these points.

set -e
if [[ "$*" != *"--set externalRegistry="* ]]; then
latest_tag=$(git ls-remote --tags $(git remote get-url origin) 'v*' | grep -o 'refs/tags/v[0-9]*\\.[0-9]*\\.[0-9]*$' | sed 's|refs/tags/||' | sort -V | tail -n 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The grep command here has a couple of issues. First, it only matches stable version tags (e.g., v1.2.3) and will exclude release candidate tags (e.g., v1.2.3-rc1). This could lead to using an older stable version of agents instead of the latest available tag if the latest is an RC. Second, the regex uses \\. to match dots. This will be interpreted by grep as a literal backslash followed by any character, which is likely not the intention. To match a literal dot, \. should be used. To fix both issues, you could use grep -E with an updated regex that correctly handles dots and optional RC versions.

  latest_tag=$(git ls-remote --tags $(git remote get-url origin) 'v*' | grep -E -o 'refs/tags/v[0-9]+\.[0-9]+\.[0-9]+(-rc[0-9]+)?$' | sed 's|refs/tags/||' | sort -V | tail -n 1)

# Platform tasks

["agentstack:start"]
depends = ["agentstack-server:build", "supergateway:build"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The depends key has been removed. This means that agentstack-server:build and supergateway:build will no longer run automatically before this task. Developers will need to run these build tasks manually. Was this intentional? If so, it might be worth documenting this change in workflow. If not, this dependency should be restored to ensure a smooth developer experience.

@jezekra1 jezekra1 merged commit 90aa5d1 into main Dec 12, 2025
8 checks passed
@jezekra1 jezekra1 deleted the minor-improvements branch December 12, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants