-
Notifications
You must be signed in to change notification settings - Fork 137
fix(server): minor improvements #1720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jezekra1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces several minor yet impactful improvements across the server's agent definitions, documentation, and development environment configuration. It streamlines the naming of a core agent, enhances the clarity of observability setup for custom agents, and refines the local development experience by automating the agent registry configuration based on the latest release, while also simplifying task dependencies. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces minor improvements, including renaming the chat agent and updating documentation. My review focuses on the changes in tasks.toml. I've identified a potential issue with how the latest git tag is determined, which could lead to using an outdated agent version. I've also noted the removal of task dependencies which might affect the developer workflow. I've provided suggestions to address these points.
| set -e | ||
| if [[ "$*" != *"--set externalRegistry="* ]]; then | ||
| latest_tag=$(git ls-remote --tags $(git remote get-url origin) 'v*' | grep -o 'refs/tags/v[0-9]*\\.[0-9]*\\.[0-9]*$' | sed 's|refs/tags/||' | sort -V | tail -n 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The grep command here has a couple of issues. First, it only matches stable version tags (e.g., v1.2.3) and will exclude release candidate tags (e.g., v1.2.3-rc1). This could lead to using an older stable version of agents instead of the latest available tag if the latest is an RC. Second, the regex uses \\. to match dots. This will be interpreted by grep as a literal backslash followed by any character, which is likely not the intention. To match a literal dot, \. should be used. To fix both issues, you could use grep -E with an updated regex that correctly handles dots and optional RC versions.
latest_tag=$(git ls-remote --tags $(git remote get-url origin) 'v*' | grep -E -o 'refs/tags/v[0-9]+\.[0-9]+\.[0-9]+(-rc[0-9]+)?$' | sed 's|refs/tags/||' | sort -V | tail -n 1)
| # Platform tasks | ||
|
|
||
| ["agentstack:start"] | ||
| depends = ["agentstack-server:build", "supergateway:build"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The depends key has been removed. This means that agentstack-server:build and supergateway:build will no longer run automatically before this task. Developers will need to run these build tasks manually. Was this intentional? If so, it might be worth documenting this change in workflow. If not, this dependency should be restored to ensure a smooth developer experience.
Signed-off-by: Radek Ježek <[email protected]>
fe277a2 to
1d693e1
Compare
Summary
Linked Issues
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.