Skip to content

fix(server): minor improvements #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jezekra1 merged 1 commit into from
Dec 12, 2025
Merged

fix(server): minor improvements #1720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agents/chat/src/chat/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@


@server.agent(
name="ChatV2",
name="Chat",
documentation_url=(
f"https://github.com/i-am-bee/agentstack/blob/{os.getenv('RELEASE_VERSION', 'main')}/agents/chat"
),
Expand Down
16 changes: 16 additions & 0 deletions docs/development/deploy-agent-stack/observability.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,22 @@ Open [http://localhost:6006](http://localhost:6006) in your browser and navigate
For an enhanced user experience and richer trace detail, consider instrumenting agents using the [OpenInference](https://github.com/Arize-ai/openinference/) standard for custom instrumentation.
</Tip>

If you have your own agent built with the Python SDK, make sure that instrumentation is enabled both in the SDK and your favorite framework:
```python
from agentstack_sdk.server import Server

# Example: BeeAI Framework instrumentation
# from openinference.instrumentation.beeai import BeeAIInstrumentor
# BeeAIInstrumentor().instrument()

server = Server()

@server.agent()
async def my_agent(): ...

server.run(configure_telemetry=True)
```

## Advanced Configuration

### Configure Langfuse Integration
Expand Down
8 changes: 6 additions & 2 deletions tasks.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,16 @@ run = "true" # Empty tests in case there are no tests
# Platform tasks

["agentstack:start"]
depends = ["agentstack-server:build", "supergateway:build"]
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The depends key has been removed. This means that agentstack-server:build and supergateway:build will no longer run automatically before this task. Developers will need to run these build tasks manually. Was this intentional? If so, it might be worth documenting this change in workflow. If not, this dependency should be restored to ensure a smooth developer experience.

dir = "{{config_root}}"
run = """
#!/bin/bash
set -e

if [[ "$*" != *"--set externalRegistry="* ]]; then
latest_tag=$(git ls-remote --tags $(git remote get-url origin) 'v*' | grep -o 'refs/tags/v[0-9]*\\.[0-9]*\\.[0-9]*$' | sed 's|refs/tags/||' | sort -V | tail -n 1)
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The grep command here has a couple of issues. First, it only matches stable version tags (e.g., v1.2.3) and will exclude release candidate tags (e.g., v1.2.3-rc1). This could lead to using an older stable version of agents instead of the latest available tag if the latest is an RC. Second, the regex uses \\. to match dots. This will be interpreted by grep as a literal backslash followed by any character, which is likely not the intention. To match a literal dot, \. should be used. To fix both issues, you could use grep -E with an updated regex that correctly handles dots and optional RC versions.

  latest_tag=$(git ls-remote --tags $(git remote get-url origin) 'v*' | grep -E -o 'refs/tags/v[0-9]+\.[0-9]+\.[0-9]+(-rc[0-9]+)?$' | sed 's|refs/tags/||' | sort -V | tail -n 1)

export AGENTSTACK__AGENT_REGISTRY="https://github.com/i-am-bee/agentstack@$latest_tag#path=agent-registry.yaml"
echo "Using agents from: $AGENTSTACK__AGENT_REGISTRY\n use --set externalRegistry=<null|github-url> to override this."
fi

UI_IMPORT=""
UI_TAG=""

Expand Down