feat: remove @iexec/interface & @iexec/solidity dep
#310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, and WorkerpoolRegistry for enhanced deployment handling
…y documentation for Iexec interfaces and methods
…f JSON files and updating initialization logic in Registry contract
…y documentation for new methods in Iexec contracts
…acet to prevent underflow and ensure backward compatibility
…y documentation for Iexec contracts
…statements in test files for consistency
Co-authored-by: Copilot <[email protected]>
…ub.com/iExecBlockchainComputing/PoCo into feature/make-v8-migration-non-breaking
…ns and adding new contract interfaces for improved clarity and organization
…rations for enhanced security in maintenance tasks
… proper formatting
…functions for improved readability
…improved error handling
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/clean-dep #310 +/- ##
===============================================
Coverage 90.08% 90.08%
===============================================
Files 38 38
Lines 1230 1230
Branches 244 244
===============================================
Hits 1108 1108
Misses 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…to streamline deployment by consolidating migration checks into _mintCreate function. This change enhances backward compatibility and prepares for future updates.
…aset structures, update function signatures, and enhance clarity by removing outdated interfaces. This update includes the addition of new methods for managing categories, datasets, and worker pools, ensuring better organization and maintainability.
Le-Caignec
commented
Oct 31, 2025
| { version: '0.4.11', settings }, // RLC contracts | ||
| { version: '0.8.21', settings: v8Settings }, // PoCo contracts | ||
| { version: '0.6.12', settings }, // External dependencies (@amxx/factory) | ||
| { version: '0.4.26', settings }, // RLC contracts - 0.4.26 is the minimum version that produces standard AST output required for storage layout checks |
Contributor
Author
There was a problem hiding this comment.
Change from 0.4.11 to 0.4.26: produces a standard ‘ast’ output
| enabled: true, | ||
| runs: 200, | ||
| }, | ||
| outputSelection: { '*': { '*': ['storageLayout'] } }, |
Contributor
Author
There was a problem hiding this comment.
This prevents Hardhat to not producing an ast in the build files.
…consistency across multiple contracts
…nd organization, consolidating interfaces and updating function signatures for improved readability
…ing in IexecERC20Core contract for better readability and maintainability
…solidate function signatures, and enhance clarity by introducing new methods for managing categories, datasets, and worker pools. This update also includes breaking changes to improve organization and maintainability.
…ate package.json to exclude TimelockController from build artifacts
…ry structure, consolidate interfaces, and enhance function signatures for better clarity and organization. This update includes breaking changes and new methods for managing categories, datasets, and worker pools.
Member
|
replaced by #319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After removing
@iexec/solidityand@iexec/interfacedependencies, all tests started failing with:Hardhat failed to initialize its network provider because Solidity 0.4.11 produces a legacyAST field in the build info instead of the modern
astfield.Since Hardhat only supports the standard
astformat, build-info files from Solidity 0.4.11 caused compatibility issues during deployment or testing.Solutions Applied
ast.astoutput for all source files.