-
Notifications
You must be signed in to change notification settings - Fork 14
chore: Remove unused iexec NPM packages @iexec/interface and @iexec/solidity
#319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes external dependencies @iexec/interface and @iexec/solidity from the project, consolidating the codebase to use locally implemented contracts instead. The changes reduce external dependencies and simplify imports.
- Removed
@iexec/interfaceand@iexec/soliditynpm packages - Consolidated
InitializableUpgradeabilityProxy__factoryimport to use the main typechain export - Updated Solidity compiler version comments for clarity
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/byContract/registries/registries.test.ts | Simplified import by removing the separate import for InitializableUpgradeabilityProxy__factory and using the main typechain export |
| package.json | Removed @iexec/interface and @iexec/solidity dependencies along with related TODO comment |
| package-lock.json | Cleaned up entries for removed dependencies and their transitive dependencies |
| hardhat.config.ts | Updated comments to reflect that 0.8.21 is used for PoCo contracts and 0.6.12 is for external dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@iexec/interface and @iexec/solidity
Le-Caignec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/solidity-v8 #319 +/- ##
==================================================
Coverage 96.32% 96.32%
==================================================
Files 34 34
Lines 1117 1117
Branches 223 223
==================================================
Hits 1076 1076
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Replace #310