Skip to content

Conversation

@zguesmi
Copy link
Member

@zguesmi zguesmi commented Nov 6, 2025

Replace #310

Copilot AI review requested due to automatic review settings November 6, 2025 17:15
@zguesmi zguesmi marked this pull request as ready for review November 6, 2025 17:16
@zguesmi zguesmi self-assigned this Nov 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes external dependencies @iexec/interface and @iexec/solidity from the project, consolidating the codebase to use locally implemented contracts instead. The changes reduce external dependencies and simplify imports.

  • Removed @iexec/interface and @iexec/solidity npm packages
  • Consolidated InitializableUpgradeabilityProxy__factory import to use the main typechain export
  • Updated Solidity compiler version comments for clarity

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
test/byContract/registries/registries.test.ts Simplified import by removing the separate import for InitializableUpgradeabilityProxy__factory and using the main typechain export
package.json Removed @iexec/interface and @iexec/solidity dependencies along with related TODO comment
package-lock.json Cleaned up entries for removed dependencies and their transitive dependencies
hardhat.config.ts Updated comments to reflect that 0.8.21 is used for PoCo contracts and 0.6.12 is for external dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Le-Caignec Le-Caignec changed the title chore: Remove unused iexec NPM packages @iexec/interface and @iexec/solidity chore: Remove unused iexec NPM packages @iexec/interface and @iexec/solidity Nov 6, 2025
Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.32%. Comparing base (7f2865f) to head (03c8988).
⚠️ Report is 1 commits behind head on chore/solidity-v8.

Additional details and impacted files
@@                Coverage Diff                 @@
##           chore/solidity-v8     #319   +/-   ##
==================================================
  Coverage              96.32%   96.32%           
==================================================
  Files                     34       34           
  Lines                   1117     1117           
  Branches                 223      223           
==================================================
  Hits                    1076     1076           
  Misses                    41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zguesmi zguesmi merged commit f30ad4a into chore/solidity-v8 Nov 6, 2025
12 checks passed
@zguesmi zguesmi deleted the chore/unused-iexec-npm-packages branch November 6, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants