chore: Remove token swap facet & generate human readable ABIs #311
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the IexecEscrowTokenSwapFacet functionality (a feature for swapping ETH/tokens via Uniswap) and introduces the hardhat-abi-exporter plugin to automate ABI generation. The changes also include improvements to import ordering, configuration updates, and pre-commit hook optimization.
- Removed unused
IexecEscrowTokenSwapFacetand related interfaces - Replaced custom ABI generation task with
hardhat-abi-exporterplugin - Updated pre-commit hooks to conditionally run documentation generation
- Improved import statement organization
Reviewed Changes
Copilot reviewed 137 out of 190 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
utils/proxy-tools.ts |
Removed imports for deleted IexecEscrowTokenSwapFacet and reordered imports alphabetically |
scripts/tools/sol-to-uml.mjs |
Removed IexecEscrowTokenSwapFacet from UML diagram generation |
package.json |
Added hardhat-abi-exporter dependency and updated configuration comments |
hardhat.config.ts |
Replaced custom abis task with abiExporter configuration and removed unused import |
deploy/0_deploy.ts |
Removed commented reference to IexecEscrowTokenSwapFacet |
contracts/interfaces/IexecEscrowTokenSwap.sol |
Deleted interface file for token swap functionality |
contracts/facets/IexecEscrowTokenSwapFacet.sol |
Deleted facet implementation file |
.solcover.js |
Simplified skip files configuration |
.husky/pre-commit |
Added conditional documentation generation |
abis/* |
Generated ABI files from new exporter plugin |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zguesmi
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
===========================================
+ Coverage 84.85% 96.53% +11.68%
===========================================
Files 37 32 -5
Lines 1241 1069 -172
Branches 235 213 -22
===========================================
- Hits 1053 1032 -21
+ Misses 188 37 -151 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 135 out of 188 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,6 @@ | |||
| #!/usr/bin/env sh | |||
There was a problem hiding this comment.
why this is not needed anymore ?
| "function EIP712DOMAIN_SEPARATOR() view returns (bytes32)", | ||
| "function GROUPMEMBER_PURPOSE() view returns (uint256)", | ||
| "function KITTY_MIN() view returns (uint256)", | ||
| "function KITTY_RATIO() view returns (uint256)", | ||
| "function WORKERPOOL_STAKE_RATIO() view returns (uint256)", |
There was a problem hiding this comment.
we should remove that maybe later
gfournierPro
left a comment
gfournierPro
left a comment
There was a problem hiding this comment.
Maybe set the architecture of folders for human-readables-abis to be like abis/ folder => one unique folder for each subfolder insteaf of a subfolder for each abi
Uh oh!
There was an error while loading. Please reload this page.