Skip to content

chore: Remove token swap facet & generate human readable ABIs #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zguesmi merged 15 commits into from
Nov 3, 2025
Merged

chore: Remove token swap facet & generate human readable ABIs #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8eb3ad9
chore: Add human readable abi of all contracts
zguesmi Oct 30, 2025
65ef4d7
chore: Clean husky v9 hook
zguesmi Oct 30, 2025
af306a4
chore: Update Sol docs only when .sol files were changed
zguesmi Oct 30, 2025
a0da4d4
chore: Move file
zguesmi Oct 30, 2025
88e7971
style: Unformat autogenerated abis file
zguesmi Oct 31, 2025
5d2e4ff
chore: Add comments
zguesmi Oct 31, 2025
68d1e1e
chore: Use hardhat-abi-exporter to produce ABIs
zguesmi Oct 31, 2025
cbb5c58
chore: Generate human readble ABIs
zguesmi Oct 31, 2025
7e9549c
chore: Ignore coverage for test contracts
zguesmi Oct 31, 2025
2c51218
chore: Remove unused `IexecEscrowTokenSwapFacet`
zguesmi Oct 31, 2025
22aa2ab
chore: Fix abi generation
zguesmi Oct 31, 2025
2f83229
chore: Merge branch 'main' into chore/remove-token-swap-facet
zguesmi Oct 31, 2025
d9e3a87
chore: Merge branch 'main' into chore/remove-token-swap-facet
zguesmi Nov 3, 2025
94afac7
chore: Clean human readable abis
zguesmi Nov 3, 2025
7e45f81
style: Ignore more autogenerated files in prettier fromat
zguesmi Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#!/usr/bin/env sh
Copy link
Contributor

@gfournierPro gfournierPro Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is not needed anymore ?


npx lint-staged
npm run doc

# Update Solidity documentation only if .sol files were changed.
if git diff --cached --name-only | grep -E '\.sol$' > /dev/null; then
npm run doc
fi
7 changes: 6 additions & 1 deletion .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ audit/
cache/
coverage/
coverage.json
deployments/
node_modules/
typechain/

# Autogenerated files
abis/
deployments/
docs/solidity/index.md
docs/solidity/templates/
13 changes: 2 additions & 11 deletions .solcover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
const BASE_FOLDER = './coverage';

module.exports = {
/**
* See https://github.com/sc-forks/solidity-coverage/issues/715 issue if
Expand All @@ -15,13 +13,6 @@ module.exports = {
mocha: {
timeout: 600000, // double timeout
},
skipFiles: [
'tools/Migrations.sol',
'tools/testing/ERC734Mock.sol',
'tools/testing/ERC1271Mock.sol',
'tools/testing/TestClient.sol',
'tools/testing/TestReceiver.sol',
'facets/SignatureVerifier.sol',
],
istanbulFolder: BASE_FOLDER,
skipFiles: ['facets/SignatureVerifier.sol', 'tools/'],
istanbulFolder: './coverage',
};
2 changes: 1 addition & 1 deletion abis/contracts/Diamond.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,4 +282,4 @@
"stateMutability": "payable",
"type": "receive"
}
]
]
2 changes: 1 addition & 1 deletion abis/contracts/IexecInterfaceNative.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4396,4 +4396,4 @@
"stateMutability": "payable",
"type": "receive"
}
]
]
2 changes: 1 addition & 1 deletion abis/contracts/IexecInterfaceToken.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4407,4 +4407,4 @@
"stateMutability": "payable",
"type": "receive"
}
]
]
2 changes: 1 addition & 1 deletion abis/contracts/external/interfaces/IERC734.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@
"stateMutability": "view",
"type": "function"
}
]
]
2 changes: 1 addition & 1 deletion abis/contracts/external/interfaces/IOracleConsumer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@
"stateMutability": "nonpayable",
"type": "function"
}
]
]
1 change: 0 additions & 1 deletion abis/contracts/facets/FacetBase.json
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion abis/contracts/facets/IexecAccessorsABILegacyFacet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,4 +312,4 @@
"stateMutability": "view",
"type": "function"
}
]
]
2 changes: 1 addition & 1 deletion abis/contracts/facets/IexecCategoryManagerFacet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,4 +59,4 @@
"stateMutability": "nonpayable",
"type": "function"
}
]
]
2 changes: 1 addition & 1 deletion abis/contracts/facets/IexecConfigurationExtraFacet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@
"stateMutability": "nonpayable",
"type": "function"
}
]
]
2 changes: 1 addition & 1 deletion abis/contracts/facets/IexecConfigurationFacet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,4 +128,4 @@
"stateMutability": "nonpayable",
"type": "function"
}
]
]
2 changes: 1 addition & 1 deletion abis/contracts/facets/IexecERC20Core.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,4 @@
"name": "Transfer",
"type": "event"
}
]
]
2 changes: 1 addition & 1 deletion abis/contracts/facets/IexecERC20Facet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,4 +203,4 @@
"stateMutability": "nonpayable",
"type": "function"
}
]
]
2 changes: 1 addition & 1 deletion abis/contracts/facets/IexecEscrow.json → abis/contracts/facets/IexecEscrow.v8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,4 +112,4 @@
"name": "Unlock",
"type": "event"
}
]
]
2 changes: 1 addition & 1 deletion abis/contracts/facets/IexecEscrowNativeFacet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,4 +169,4 @@
"stateMutability": "payable",
"type": "receive"
}
]
]
2 changes: 1 addition & 1 deletion abis/contracts/facets/IexecEscrowTokenFacet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,4 +214,4 @@
"stateMutability": "payable",
"type": "receive"
}
]
]
Loading